From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754503AbcGFNer (ORCPT <rfc822;w@1wt.eu>);
	Wed, 6 Jul 2016 09:34:47 -0400
Received: from down.free-electrons.com ([37.187.137.238]:46466 "EHLO
	mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org
	with ESMTP id S1751834AbcGFNeq (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 6 Jul 2016 09:34:46 -0400
Date: Wed, 6 Jul 2016 15:34:44 +0200
From: Alexandre Belloni <alexandre.belloni@free-electrons.com>
To: Wei Yongjun <weiyj_lk@163.com>
Cc: Boris Brezillon <boris.brezillon@free-electrons.com>,
        Nicolas Ferre <nicolas.ferre@atmel.com>,
        Paul Gortmaker <paul.gortmaker@windriver.com>,
        Wei Yongjun <yongjun_wei@trendmicro.com.cn>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next] memory: atmel-ebi: use PTR_ERR_OR_ZERO() to
 simplify the code
Message-ID: <20160706133444.GD3623@piout.net>
References: <1467806885-25578-1-git-send-email-weiyj_lk@163.com>
 <20160706121817.GC3623@piout.net>
 <8d02ef0b-f2d0-81c5-0048-36064f3e7955@163.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <8d02ef0b-f2d0-81c5-0048-36064f3e7955@163.com>
User-Agent: Mutt/1.6.0 (2016-04-01)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 06/07/2016 at 21:19:34 +0800, Wei Yongjun wrote :
> Hi,
> 
> On 07/06/2016 08:18 PM, Alexandre Belloni wrote:
> > Hi,
> >
> > On 06/07/2016 at 12:08:05 +0000, weiyj_lk@163.com wrote :
> >> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
> >>
> >> Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR.
> >>
> > I'm guessing you found that using coccinnelle or any other static
> > analysis tool. Can you mention that in the commit message?
> >
> Your are right, this patch is found by coccinelle and created by scripts.
> (I called it dpatch, a kernel patch IDE, which had integrated coccinelle,
> sparse engine, scripts to found and create kernel patch.
> REF: https://github.com/weiyj/dpatch-devel).
> 
> I mentioned those in passed, but no all of people like this.
> 

Well it helps knowing whether this has been tested on actual hardware or
not.

-- 
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com