From: "J. Bruce Fields" <bfields@fieldses.org>
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc: jlayton@poochiereds.net, linux-nfs@vger.kernel.org,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 2/2] nfsd: remove extraneous KERN_INFO prefix
Date: Wed, 6 Jul 2016 09:52:23 -0400 [thread overview]
Message-ID: <20160706135223.GD18856@fieldses.org> (raw)
In-Reply-To: <1467440688-8368-1-git-send-email-christophe.jaillet@wanadoo.fr>
Thanks, applying both patches.--b.
On Sat, Jul 02, 2016 at 08:24:48AM +0200, Christophe JAILLET wrote:
> smatch complains about using KERN_INFO as a prefix when calling dprintk
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
> fs/nfsd/nfs4state.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/nfsd/nfs4state.c b/fs/nfsd/nfs4state.c
> index bc2173a..ba6b2df 100644
> --- a/fs/nfsd/nfs4state.c
> +++ b/fs/nfsd/nfs4state.c
> @@ -2226,7 +2226,7 @@ gen_callback(struct nfs4_client *clp, struct nfsd4_setclientid *se, struct svc_r
> out_err:
> conn->cb_addr.ss_family = AF_UNSPEC;
> conn->cb_addrlen = 0;
> - dprintk(KERN_INFO "NFSD: this client (clientid %08x/%08x) "
> + dprintk("NFSD: this client (clientid %08x/%08x) "
> "will not receive delegations\n",
> clp->cl_clientid.cl_boot, clp->cl_clientid.cl_id);
>
> --
> 2.7.4
prev parent reply other threads:[~2016-07-06 13:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-02 6:24 [PATCH 2/2] nfsd: remove extraneous KERN_INFO prefix Christophe JAILLET
2016-07-06 13:52 ` J. Bruce Fields [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160706135223.GD18856@fieldses.org \
--to=bfields@fieldses.org \
--cc=christophe.jaillet@wanadoo.fr \
--cc=jlayton@poochiereds.net \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox