From: Tejun Heo <tj@kernel.org>
To: aaronlee0817 <aaronlee0817@163.com>
Cc: axboe@kernel.dk, mlin@kernel.org, shli@kernel.org,
linux-kernel@vger.kernel.org, cgroup@vger.kernel.org,
jiale0817.li@samsung.com, yanzi.zhang@samsung.com,
zhen1.zhang@samsung.com, linux-block@vger.kernel.org
Subject: Re: Re: cgroup: Fix split bio been throttled more than once
Date: Wed, 6 Jul 2016 11:06:29 -0400 [thread overview]
Message-ID: <20160706150629.GA31684@mtj.duckdns.org> (raw)
In-Reply-To: <458d1946.12fa6.155c0b80d60.Coremail.aaronlee0817@163.com>
Hello,
On Wed, Jul 06, 2016 at 10:58:55PM +0800, aaronlee0817 wrote:
> >But that said, can't we just copy BIO_THROTLED while splitting?
>
> In my opinion， copying BIO_THROTLED while splitting doesn't work
> with this, because, the bio within the limit will not set BIO_THROTLED
> but will be split, and back to call generic_make_request(), and will be
> count twice.
I see. It's just a bit weird that we're marking this from clone site
when it's an issue which is specific to throttling. The thing is
depending on how bio clone is used, it could misbehave in the other
direction (bio not accounted at all). What we want to know is whether
a bio has been previously accounted or not, rather than whether a bio
is a result of splitting. I think it'd be better to track that
instead.
Thanks.
--
tejun
next prev parent reply other threads:[~2016-07-06 15:06 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-04 14:46 cgroup: Fix split bio been throttled more than once Jiale Li
2016-07-05 22:26 ` Tejun Heo
2016-07-06 1:14 ` Ming Lei
[not found] ` <458d1946.12fa6.155c0b80d60.Coremail.aaronlee0817@163.com>
2016-07-06 15:06 ` Tejun Heo [this message]
2016-07-06 15:39 ` Ming Lei
2016-07-06 1:10 ` Ming Lei
2016-07-06 14:09 ` Tejun Heo
2016-07-06 14:53 ` Ming Lei
[not found] ` <27824f6f.127ab.155c59d8a24.Coremail.aaronlee0817@163.com>
2016-07-08 10:35 ` Ming Lei
2016-07-09 14:53 ` Tejun Heo
2016-07-10 8:58 ` Ming Lei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160706150629.GA31684@mtj.duckdns.org \
--to=tj@kernel.org \
--cc=aaronlee0817@163.com \
--cc=axboe@kernel.dk \
--cc=cgroup@vger.kernel.org \
--cc=jiale0817.li@samsung.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mlin@kernel.org \
--cc=shli@kernel.org \
--cc=yanzi.zhang@samsung.com \
--cc=zhen1.zhang@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).