From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754809AbcGFQps (ORCPT ); Wed, 6 Jul 2016 12:45:48 -0400 Received: from mail1.windriver.com ([147.11.146.13]:39684 "EHLO mail1.windriver.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753813AbcGFQpr (ORCPT ); Wed, 6 Jul 2016 12:45:47 -0400 Date: Wed, 6 Jul 2016 12:45:38 -0400 From: Paul Gortmaker To: Laxman Dewangan CC: , Samuel Ortiz , Lee Jones , Florian Lobmaier Subject: Re: [PATCH 2/6] mfd: as3722: Make it explicitly non-modular Message-ID: <20160706164538.GI26134@windriver.com> References: <20160705012544.14143-1-paul.gortmaker@windriver.com> <20160705012544.14143-3-paul.gortmaker@windriver.com> <577B4A30.4050303@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <577B4A30.4050303@nvidia.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org [Re: [PATCH 2/6] mfd: as3722: Make it explicitly non-modular] On 05/07/2016 (Tue 11:18) Laxman Dewangan wrote: > > On Tuesday 05 July 2016 06:55 AM, Paul Gortmaker wrote: > >The Kconfig currently controlling compilation of this code is: > > > >drivers/mfd/Kconfig:config MFD_AS3722 > >drivers/mfd/Kconfig: bool "ams AS3722 Power Management IC" > > > > > Should we convert this to as "tristate" so that it can be built as module > also. Seems to compile and modpost w/o missing symbols as tristate: paul@yow-builder:~/git/linux-head$ ls -l ../arm-build/drivers/mfd/as3722* -rw-rw-r-- 1 paul paul 13010 Jul 6 12:30 ../arm-build/drivers/mfd/as3722.ko -rw-rw-r-- 1 paul paul 1937 Jul 6 12:28 ../arm-build/drivers/mfd/as3722.mod.c -rw-rw-r-- 1 paul paul 3820 Jul 6 12:29 ../arm-build/drivers/mfd/as3722.mod.o -rw-rw-r-- 1 paul paul 11292 Jul 6 12:13 ../arm-build/drivers/mfd/as3722.o paul@yow-builder:~/git/linux-head$ ...so I'll drop this patch in favour of the one line tristate conversion in v2. Paul. --