From: Vinod Koul <vinod.koul@intel.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Dan Williams <dan.j.williams@intel.com>,
Andy Gross <andy.gross@linaro.org>,
Stanimir Varbanov <stanimir.varbanov@linaro.org>,
dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dmaengine: qcom-bam-dma: add __maybe_unused annotations for PM
Date: Wed, 6 Jul 2016 22:40:04 +0530 [thread overview]
Message-ID: <20160706171004.GD12591@localhost> (raw)
In-Reply-To: <20160704131440.1027790-1-arnd@arndb.de>
On Mon, Jul 04, 2016 at 03:14:08PM +0200, Arnd Bergmann wrote:
> The bam_dma driver gained runtime PM support, but that causes build
> warnings whenever CONFIG_PM is disabled:
>
> drivers/dma/qcom/bam_dma.c:1324:12: error: 'bam_dma_runtime_resume' defined but not used [-Werror=unused-function]
> static int bam_dma_runtime_resume(struct device *dev)
> ^~~~~~~~~~~~~~~~~~~~~~
> drivers/dma/qcom/bam_dma.c:1315:12: error: 'bam_dma_runtime_suspend' defined but not used [-Werror=unused-function]
> static int bam_dma_runtime_suspend(struct device *dev)
>
> This removes the incomplete #ifdef guard and instead marks all
> four PM functions as __maybe_unused, which avoids this kind of
> warning.
Applied, thanks
--
~Vinod
prev parent reply other threads:[~2016-07-06 17:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-04 13:14 [PATCH] dmaengine: qcom-bam-dma: add __maybe_unused annotations for PM Arnd Bergmann
2016-07-06 17:10 ` Vinod Koul [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160706171004.GD12591@localhost \
--to=vinod.koul@intel.com \
--cc=andy.gross@linaro.org \
--cc=arnd@arndb.de \
--cc=dan.j.williams@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stanimir.varbanov@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox