From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755371AbcGFRDC (ORCPT ); Wed, 6 Jul 2016 13:03:02 -0400 Received: from mga01.intel.com ([192.55.52.88]:16798 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754168AbcGFRDA (ORCPT ); Wed, 6 Jul 2016 13:03:00 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,320,1464678000"; d="scan'208";a="1001981210" Date: Wed, 6 Jul 2016 22:40:04 +0530 From: Vinod Koul To: Arnd Bergmann Cc: Dan Williams , Andy Gross , Stanimir Varbanov , dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] dmaengine: qcom-bam-dma: add __maybe_unused annotations for PM Message-ID: <20160706171004.GD12591@localhost> References: <20160704131440.1027790-1-arnd@arndb.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160704131440.1027790-1-arnd@arndb.de> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jul 04, 2016 at 03:14:08PM +0200, Arnd Bergmann wrote: > The bam_dma driver gained runtime PM support, but that causes build > warnings whenever CONFIG_PM is disabled: > > drivers/dma/qcom/bam_dma.c:1324:12: error: 'bam_dma_runtime_resume' defined but not used [-Werror=unused-function] > static int bam_dma_runtime_resume(struct device *dev) > ^~~~~~~~~~~~~~~~~~~~~~ > drivers/dma/qcom/bam_dma.c:1315:12: error: 'bam_dma_runtime_suspend' defined but not used [-Werror=unused-function] > static int bam_dma_runtime_suspend(struct device *dev) > > This removes the incomplete #ifdef guard and instead marks all > four PM functions as __maybe_unused, which avoids this kind of > warning. Applied, thanks -- ~Vinod