Re: [PATCH -next] ARM: dts: sun8i: Add NFC node to Allwinner A23/A33 SoC

Re: [PATCH -next] ARM: dts: sun8i: Add NFC node to Allwinner A23/A33 SoC

[Maxime Ripard]

[-- Attachment #1: Type: text/plain, Size: 1060 bytes --]

Hi,

On Wed, Jul 06, 2016 at 08:33:52AM +0800, Icenowy Zheng wrote:
> Add NAND Flash controller node definition to the A23/A33 SoC.
> 
> Signed-off-by: Icenowy Zheng <icenowy@aosc.xyz>

Has this ever been tested? On what board, with what NAND chip?

> ---
>  arch/arm/boot/dts/sun8i-a23-a33.dtsi | 23 +++++++++++++++++++++++
>  1 file changed, 23 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/sun8i-a23-a33.dtsi b/arch/arm/boot/dts/sun8i-a23-a33.dtsi
> index 7e05e09..270c38a 100644
> --- a/arch/arm/boot/dts/sun8i-a23-a33.dtsi
> +++ b/arch/arm/boot/dts/sun8i-a23-a33.dtsi
> @@ -209,6 +209,14 @@
>  					"apb2_uart3", "apb2_uart4";
>  		};
>  
> +		nand_clk: clk@01c20080 {
> +			#clock-cells = <0>;
> +			compatible = "allwinner,sun4i-a10-mod0-clk";
> +			reg = <0x01c20080 0x4>;
> +			clocks = <&osc24M>, <&pll6 1>;
> +			clock-output-names = "nand";
> +		};
> +

This should be in a separate patch.

Thanks!
Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: [PATCH -next] ARM: dts: sun8i: Add NFC node to Allwinner A23/A33 SoC

[Maxime Ripard]

[-- Attachment #1: Type: text/plain, Size: 579 bytes --]

On Thu, Jul 07, 2016 at 08:04:41AM +0800, Icenowy Zheng wrote:
> with a http://linux-sunxi.org/Aoson_M751s tablet, (SKhynix
> H27UCG8T2ETR-BC NAND chip).
> 
> I used the patchset at
> http://lists.infradead.org/pipermail/linux-mtd/2016-June/067848.html
> to ensure the NAND chip to work properly (otherwise the chip id
> cannot be correctly identified)

(Please reply in-line and wrap your mails).

Ok. That needs to be in the commit log then.

Thanks!
Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]