Re: [PATCH 1/1] usb: core: of.c: fix defined but not declare warning

Peter Chen
2016-07-07T09:27:11Z

On Wed, Jun 15, 2016 at 11:25:43AM +0800, Peter Chen wrote:
> The helper usb_of_get_child_node is defined at of.c, but missing its
> declare as a global function. Fix it by adding related header file
> as well as compile it on conditional of CONFIG_OF.
>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: Arnd Bergmann <arnd@arndb.de>
> Cc: Alan Stern <stern@rowland.harvard.edu>
> Cc: linux-usb@vger.kernel.org
> Cc: linux-kernel@vger.kernel.org
> Cc: Ben Dooks <ben.dooks@codethink.co.uk>
> Cc: linux-kernel@lists.codethink.co.uk
>
> Signed-off-by: Peter Chen <peter.chen@nxp.com>
> Reported-by: Ben Dooks <ben.dooks@codethink.co.uk>
> ---
> drivers/usb/core/Makefile | 3 ++-
> drivers/usb/core/of.c | 1 +
> 2 files changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/usb/core/Makefile b/drivers/usb/core/Makefile
> index 9780877..da36b78 100644
> --- a/drivers/usb/core/Makefile
> +++ b/drivers/usb/core/Makefile
> @@ -5,8 +5,9 @@
> usbcore-y := usb.o hub.o hcd.o urb.o message.o driver.o
> usbcore-y += config.o file.o buffer.o sysfs.o endpoint.o
> usbcore-y += devio.o notify.o generic.o quirks.o devices.o
> -usbcore-y += port.o of.o
> +usbcore-y += port.o
>
> +usbcore-$(CONFIG_OF) += of.o
> usbcore-$(CONFIG_PCI) += hcd-pci.o
> usbcore-$(CONFIG_ACPI) += usb-acpi.o
>
> diff --git a/drivers/usb/core/of.c b/drivers/usb/core/of.c
> index 2289700..3de4f88 100644
> --- a/drivers/usb/core/of.c
> +++ b/drivers/usb/core/of.c
> @@ -18,6 +18,7 @@
> */
>
> #include <linux/of.h>
> +#include <linux/usb/of.h>
>

ping...

--

Best Regards,
Peter Chen