* [PATCH] xen-blkback: constify instance of "struct attribute_group"
@ 2016-07-07 7:38 Jan Beulich
2016-07-07 9:45 ` Roger Pau Monne
0 siblings, 1 reply; 6+ messages in thread
From: Jan Beulich @ 2016-07-07 7:38 UTC (permalink / raw)
To: Roger Pau Monne, Konrad Rzeszutek Wilk; +Cc: xen-devel, linux-kernel
The functions such get passed to have been taking pointers to const
since at least 2.6.16.
Signed-off-by: Jan Beulich <jbeulich@suse.com>
---
drivers/block/xen-blkback/xenbus.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- 4.7-rc6-xen.orig/drivers/block/xen-blkback/xenbus.c
+++ 4.7-rc6-xen/drivers/block/xen-blkback/xenbus.c
@@ -379,7 +379,7 @@ static struct attribute *xen_vbdstat_att
NULL
};
-static struct attribute_group xen_vbdstat_group = {
+static const struct attribute_group xen_vbdstat_group = {
.name = "statistics",
.attrs = xen_vbdstat_attrs,
};
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] xen-blkback: constify instance of "struct attribute_group"
2016-07-07 7:38 [PATCH] xen-blkback: constify instance of "struct attribute_group" Jan Beulich
@ 2016-07-07 9:45 ` Roger Pau Monne
2016-07-07 9:52 ` [Xen-devel] " Andrew Cooper
0 siblings, 1 reply; 6+ messages in thread
From: Roger Pau Monne @ 2016-07-07 9:45 UTC (permalink / raw)
To: Jan Beulich; +Cc: Konrad Rzeszutek Wilk, xen-devel, linux-kernel
On Thu, Jul 07, 2016 at 01:38:58AM -0600, Jan Beulich wrote:
> The functions such get passed to have been taking pointers to const
> since at least 2.6.16.
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
Acked-by: Roger Pau Monné <roger.pau@citrix.com>
Although the wording in the commit message looks weird to me, but I'm not a
native speaker anyway.
Roger.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Xen-devel] [PATCH] xen-blkback: constify instance of "struct attribute_group"
2016-07-07 9:45 ` Roger Pau Monne
@ 2016-07-07 9:52 ` Andrew Cooper
2016-07-07 15:37 ` Konrad Rzeszutek Wilk
0 siblings, 1 reply; 6+ messages in thread
From: Andrew Cooper @ 2016-07-07 9:52 UTC (permalink / raw)
To: Roger Pau Monne, Jan Beulich; +Cc: xen-devel, linux-kernel
On 07/07/16 10:45, Roger Pau Monne wrote:
> On Thu, Jul 07, 2016 at 01:38:58AM -0600, Jan Beulich wrote:
>> The functions such get passed to have been taking pointers to const
>> since at least 2.6.16.
>>
>> Signed-off-by: Jan Beulich <jbeulich@suse.com>
> Acked-by: Roger Pau Monné <roger.pau@citrix.com>
>
> Although the wording in the commit message looks weird to me, but I'm not a
> native speaker anyway.
As a native speaker, I can't parse it either.
I think s/such/these/ is needed.
~Andrew
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Xen-devel] [PATCH] xen-blkback: constify instance of "struct attribute_group"
2016-07-07 9:52 ` [Xen-devel] " Andrew Cooper
@ 2016-07-07 15:37 ` Konrad Rzeszutek Wilk
2016-07-07 15:57 ` Jan Beulich
0 siblings, 1 reply; 6+ messages in thread
From: Konrad Rzeszutek Wilk @ 2016-07-07 15:37 UTC (permalink / raw)
To: Andrew Cooper; +Cc: Roger Pau Monne, Jan Beulich, xen-devel, linux-kernel
On Thu, Jul 07, 2016 at 10:52:18AM +0100, Andrew Cooper wrote:
> On 07/07/16 10:45, Roger Pau Monne wrote:
> > On Thu, Jul 07, 2016 at 01:38:58AM -0600, Jan Beulich wrote:
> >> The functions such get passed to have been taking pointers to const
> >> since at least 2.6.16.
> >>
> >> Signed-off-by: Jan Beulich <jbeulich@suse.com>
> > Acked-by: Roger Pau Monné <roger.pau@citrix.com>
> >
> > Although the wording in the commit message looks weird to me, but I'm not a
> > native speaker anyway.
>
> As a native speaker, I can't parse it either.
>
> I think s/such/these/ is needed.
The functions such as these have been taking pointers to const
since at least 2.6.16.
?
>
> ~Andrew
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> https://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Xen-devel] [PATCH] xen-blkback: constify instance of "struct attribute_group"
2016-07-07 15:37 ` Konrad Rzeszutek Wilk
@ 2016-07-07 15:57 ` Jan Beulich
2016-07-08 13:55 ` Konrad Rzeszutek Wilk
0 siblings, 1 reply; 6+ messages in thread
From: Jan Beulich @ 2016-07-07 15:57 UTC (permalink / raw)
To: Andrew Cooper, Konrad Rzeszutek Wilk
Cc: Roger Pau Monne, xen-devel, linux-kernel
>>> On 07.07.16 at 17:37, <konrad.wilk@oracle.com> wrote:
> On Thu, Jul 07, 2016 at 10:52:18AM +0100, Andrew Cooper wrote:
>> On 07/07/16 10:45, Roger Pau Monne wrote:
>> > On Thu, Jul 07, 2016 at 01:38:58AM -0600, Jan Beulich wrote:
>> >> The functions such get passed to have been taking pointers to const
>> >> since at least 2.6.16.
>> >>
>> >> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>> > Acked-by: Roger Pau Monné <roger.pau@citrix.com>
>> >
>> > Although the wording in the commit message looks weird to me, but I'm not a
>
>> > native speaker anyway.
>>
>> As a native speaker, I can't parse it either.
>>
>> I think s/such/these/ is needed.
>
> The functions such as these have been taking pointers to const
> since at least 2.6.16.
I had taken Andrew's suggestion literally and changed it to "The
functions these get passed to have been taking pointers to const
since at least 2.6.16" for a possible (if needed) resubmission.
Jan
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Xen-devel] [PATCH] xen-blkback: constify instance of "struct attribute_group"
2016-07-07 15:57 ` Jan Beulich
@ 2016-07-08 13:55 ` Konrad Rzeszutek Wilk
0 siblings, 0 replies; 6+ messages in thread
From: Konrad Rzeszutek Wilk @ 2016-07-08 13:55 UTC (permalink / raw)
To: Jan Beulich; +Cc: Andrew Cooper, Roger Pau Monne, xen-devel, linux-kernel
On Thu, Jul 07, 2016 at 09:57:10AM -0600, Jan Beulich wrote:
> >>> On 07.07.16 at 17:37, <konrad.wilk@oracle.com> wrote:
> > On Thu, Jul 07, 2016 at 10:52:18AM +0100, Andrew Cooper wrote:
> >> On 07/07/16 10:45, Roger Pau Monne wrote:
> >> > On Thu, Jul 07, 2016 at 01:38:58AM -0600, Jan Beulich wrote:
> >> >> The functions such get passed to have been taking pointers to const
> >> >> since at least 2.6.16.
> >> >>
> >> >> Signed-off-by: Jan Beulich <jbeulich@suse.com>
> >> > Acked-by: Roger Pau Monné <roger.pau@citrix.com>
> >> >
> >> > Although the wording in the commit message looks weird to me, but I'm not a
> >
> >> > native speaker anyway.
> >>
> >> As a native speaker, I can't parse it either.
> >>
> >> I think s/such/these/ is needed.
> >
> > The functions such as these have been taking pointers to const
> > since at least 2.6.16.
>
> I had taken Andrew's suggestion literally and changed it to "The
> functions these get passed to have been taking pointers to const
> since at least 2.6.16" for a possible (if needed) resubmission.
No need to resubmit. I will use Andrew's suggestion.
>
> Jan
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-07-08 13:56 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-07-07 7:38 [PATCH] xen-blkback: constify instance of "struct attribute_group" Jan Beulich
2016-07-07 9:45 ` Roger Pau Monne
2016-07-07 9:52 ` [Xen-devel] " Andrew Cooper
2016-07-07 15:37 ` Konrad Rzeszutek Wilk
2016-07-07 15:57 ` Jan Beulich
2016-07-08 13:55 ` Konrad Rzeszutek Wilk
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox