From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752234AbcGGKdI (ORCPT ); Thu, 7 Jul 2016 06:33:08 -0400 Received: from mga09.intel.com ([134.134.136.24]:28349 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750987AbcGGKdG (ORCPT ); Thu, 7 Jul 2016 06:33:06 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,324,1464678000"; d="scan'208";a="990651569" Date: Thu, 7 Jul 2016 13:33:01 +0300 From: Mika Westerberg To: Andy Shevchenko Cc: Paul Gortmaker , linux-kernel@vger.kernel.org, Lee Jones Subject: Re: [PATCH 3/6] mfd: intel_msic: Make it explicitly non-modular Message-ID: <20160707103301.GS23527@lahna.fi.intel.com> References: <20160705012544.14143-1-paul.gortmaker@windriver.com> <20160705012544.14143-4-paul.gortmaker@windriver.com> <20160705100821.GK23527@lahna.fi.intel.com> <20160706163800.GH26134@windriver.com> <20160707081130.GI23527@lahna.fi.intel.com> <1467887195.30123.494.camel@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1467887195.30123.494.camel@linux.intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.6.1 (2016-04-27) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jul 07, 2016 at 01:26:35PM +0300, Andy Shevchenko wrote: > On Thu, 2016-07-07 at 11:11 +0300, Mika Westerberg wrote: > > On Wed, Jul 06, 2016 at 12:38:00PM -0400, Paul Gortmaker wrote: > > > [Re: [PATCH 3/6] mfd: intel_msic: Make it explicitly non-modular] On > > > 05/07/2016 (Tue 13:08) Mika Westerberg wrote: > > > > > > > On Mon, Jul 04, 2016 at 09:25:41PM -0400, Paul Gortmaker wrote: > > > > > The Kconfig currently controlling compilation of this code is: > > > > > > > > > > drivers/mfd/Kconfig:config MFD_INTEL_MSIC > > > > > drivers/mfd/Kconfig:    bool "Intel MSIC" > > > > > > > > I would prefer if it could be turned to tristate instead. I don't > > > > see > > > > any reasons why it should only be builtin. > > > > > > If I change it to tristate, it is still impossible to choose =m for > > > it > > > unless I revert your earlier commit forcing it to be built in. > > > > > > commit 15a713df4145ad2540f8d84c3f4de930806f6151 > > > Author: Mika Westerberg > > > Date:   Thu Jan 26 17:35:05 2012 +0000 > > > > > >     x86/config: Select MSIC MFD driver on Intel Medfield platform > > >      > > >     On Intel Medfield platform we use MSIC MFD driver to create > > >     necessary platform devices so it is essential to have the driver > > >     compiled into the kernel. > > > > > > If I revert that, then it is possible to choose =m and it compiles. > > > (haven't completed modpost yet.. so may be missing symbols...) > > > > I think we can revert that and make it modular. Adding Andy just in > > case > > I'm missing something obvious. > > I doubt we may do this. The MID platforms MSIC used for some voltage > regulations and other stuff, moreover it exports an API which might be > used by the code which can be (for now) only compiled in. I wouldn't > take a headache to convert users and check all possible Kconfig > variations (check this gpio-msic.c). OK, thanks Andy. So I withdraw my comment about tristating the driver. Let's make it explictly non-modular then. For the patch, Acked-by: Mika Westerberg