From: Eric Engestrom <eric.engestrom@imgtec.com>
To: Markus Mayer <mmayer@broadcom.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Al Viro <viro@zeniv.linux.org.uk>,
Rasmus Villemoes <linux@rasmusvillemoes.dk>,
Chris Metcalf <cmetcalf@ezchip.com>,
Kees Cook <keescook@chromium.org>, <devel@driverdev.osuosl.org>,
<linux-scsi@vger.kernel.org>, <linux-pm@vger.kernel.org>,
<nouveau@lists.freedesktop.org>, <speakup@linux-speakup.org>,
<linux-kernel@vger.kernel.org>, <dri-devel@lists.freedesktop.org>,
<linux-acpi@vger.kernel.org>, <target-devel@vger.kernel.org>
Subject: Re: [PATCH v2 1/7] lib: string: add functions to case-convert strings
Date: Thu, 7 Jul 2016 12:04:53 +0100 [thread overview]
Message-ID: <20160707110453.GC3417@imgtec.com> (raw)
In-Reply-To: <1467751631-22878-2-git-send-email-mmayer@broadcom.com>
On Tue, Jul 05, 2016 at 01:47:05PM -0700, Markus Mayer wrote:
> All functions return a pointer to the terminating '\0' character in the
> modified string ("dst" or "s", respectively).
I think this is going to be confusing. From the man:
The strcpy() and strncpy() functions return a pointer to the
destination string dest.
I think it would be better to keep the same behaviour, especially since
you used the same name for your functions (which I think is sensible),
not to mention you don't use this return value in any of your calls.
(IMHO strcpy() shouldn't have had a return value and neither should your
functions, but since it does, yours should match.)
Cheers,
Eric
next prev parent reply other threads:[~2016-07-07 11:06 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-05 20:47 [PATCH v2 0/7] lib: string: add functions to case-convert strings Markus Mayer
2016-07-05 20:47 ` [PATCH v2 1/7] " Markus Mayer
2016-07-07 11:04 ` Eric Engestrom [this message]
2016-07-08 0:19 ` Rasmus Villemoes
2016-07-08 18:04 ` Markus Mayer
2016-07-05 20:47 ` [PATCH v2 2/7] drm/nouveau/core: make use of new strncpytolower() function Markus Mayer
2016-07-05 20:47 ` [PATCH v2 3/7] ACPI / device_sysfs: make use of new strtolower() function Markus Mayer
2016-07-05 20:47 ` [PATCH v2 4/7] staging: speakup: replace spk_strlwr() with strncpytolower() Markus Mayer
2016-07-05 20:47 ` [PATCH v2 5/7] iscsi-target: replace iscsi_initiatorname_tolower() with strtolower() Markus Mayer
2016-07-05 20:47 ` [PATCH v2 6/7] drm/nouveau/fifo/gk104: make use of new strcpytoupper() function Markus Mayer
2016-07-05 20:47 ` [PATCH v2 7/7] power_supply: " Markus Mayer
2016-07-05 22:14 ` [PATCH v2 0/7] lib: string: add functions to case-convert strings Joe Perches
2016-07-05 22:36 ` Markus Mayer
2016-07-05 22:56 ` Joe Perches
2016-07-06 4:32 ` Markus Mayer
2016-07-07 5:05 ` [Nouveau] " Alexandre Courbot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160707110453.GC3417@imgtec.com \
--to=eric.engestrom@imgtec.com \
--cc=akpm@linux-foundation.org \
--cc=cmetcalf@ezchip.com \
--cc=devel@driverdev.osuosl.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=keescook@chromium.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=mmayer@broadcom.com \
--cc=nouveau@lists.freedesktop.org \
--cc=speakup@linux-speakup.org \
--cc=target-devel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox