From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753708AbcGGXOt (ORCPT ); Thu, 7 Jul 2016 19:14:49 -0400 Received: from quartz.orcorp.ca ([184.70.90.242]:34193 "EHLO quartz.orcorp.ca" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753044AbcGGXOk (ORCPT ); Thu, 7 Jul 2016 19:14:40 -0400 Date: Thu, 7 Jul 2016 17:14:23 -0600 From: Jason Gunthorpe To: Roland Dreier Cc: Alexander Duyck , Konstantin Khlebnikov , "linux-rdma@vger.kernel.org" , Florian Westphal , Thadeu Lima de Souza Cascardo , Cong Wang , Linux Kernel Network Developers , David Miller , Eric Dumazet , Linux Kernel Mailing List Subject: Re: Resurrecting due to huge ipoib perf regression - [BUG] skb corruption and kernel panic at forwarding with fragmentation Message-ID: <20160707231423.GA21039@obsidianresearch.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) X-Broken-Reverse-DNS: no host name found for IP address 10.0.0.160 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jul 07, 2016 at 03:01:40PM -0700, Roland Dreier wrote: > The reason we moved to the cb storage is that in the past, trying to > hide some data in the actual skb buffer that we don't actually send We have neighbour_priv, and ndo_neigh_construct/destruct now .. A first blush that would seem to be enough to let ipoib store the AH and other path information in the neigh and avoid the cb? At least the example in clip sure looks like what ipoib needs to do. Jason