From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751971AbcGHEgh (ORCPT ); Fri, 8 Jul 2016 00:36:37 -0400 Received: from leo.clearchain.com ([199.73.29.74]:48163 "EHLO mail.clearchain.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750858AbcGHEgf (ORCPT ); Fri, 8 Jul 2016 00:36:35 -0400 Date: Fri, 8 Jul 2016 14:34:15 +1000 From: Peter Hutterer To: Bastien Nocera Cc: Jiri Kosina , Benjamin Tissoires , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, Nestor Lopez Casado Subject: Re: [PATCH 1/2] HID: logitech-hidpp: add battery support for HID++ 2.0 devices Message-ID: <20160708043415.GA3691@jelly> References: <1467192482-2723-1-git-send-email-peter.hutterer@who-t.net> <1467933668.25410.3.camel@hadess.net> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1467933668.25410.3.camel@hadess.net> User-Agent: Mutt/1.6.1 (2016-04-27) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.4.3 (mail.clearchain.com [127.0.0.1]); Fri, 08 Jul 2016 14:05:38 +0930 (CST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jul 08, 2016 at 01:21:08AM +0200, Bastien Nocera wrote: > On Wed, 2016-06-29 at 19:28 +1000, Peter Hutterer wrote: > > If the 0x1000 Unified Battery Level Status feature exists, expose the > > battery > > level. > > > > The main drawback is that while a device is plugged in its battery > > level is 0. > > To avoid exposing that as 0% charge we make up a number based on the > > charging > > status. > > This will require changes in UPower, so that it doesn't try to access > the Logitech unifying devices via user-space, and uses the data from > the kernel. Did you already file a bug? filed now: https://bugs.freedesktop.org/show_bug.cgi?id=96857 > Note that this would also mean losing the "lux" information, but I > don't think that's something we're that interested in exposing. Adding that HID++ request to the kernel would be easy enough but I don't see anything in the power_supply_property that would match this, do you? Also, I don't have such a device so testing would be tricky. Cheers, Peter > > For example, for a keyboard that recharges via solar panels, at night: > > Device: /org/freedesktop/UPower/devices/keyboard_0003o046Do4002x0004 >   native-path:          /sys/devices/pci0000:00/0000:00:14.0/usb3/3-10/3-10:1.2/0003:046D:C52B.0003/0003:046D:4002.0004 >   vendor:               Logitech, Inc. >   model:                K750 >   serial:               197F3F23 >   power supply:         no >   updated:              Fri 08 Jul 2016 01:17:40 CEST (95 seconds ago) >   has history:          yes >   has statistics:       no >   keyboard >     present:             yes >     rechargeable:        yes >     state:               discharging >     warning-level:       none >     luminosity:          16 lx >     percentage:          89% >     icon-name:          'battery-full-symbolic'