From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754093AbcGHHzZ (ORCPT ); Fri, 8 Jul 2016 03:55:25 -0400 Received: from mx1.redhat.com ([209.132.183.28]:49389 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752008AbcGHHzT (ORCPT ); Fri, 8 Jul 2016 03:55:19 -0400 Date: Fri, 8 Jul 2016 09:55:14 +0200 From: Jiri Olsa To: Mark Rutland Cc: linux-kernel@vger.kernel.org, acme@kernel.org, adrian.hunter@intel.com, alexander.shishkin@linux.intel.com, hekuang@huawei.com, jolsa@kernel.org, kan.liang@intel.com, mingo@redhat.com, peterz@infradead.org, wangnan0@huawei.com Subject: Re: [RFC PATCH 3/3] perf: util: only open events on CPUs an evsel permits Message-ID: <20160708075514.GA26532@krava> References: <1467907474-3290-1-git-send-email-mark.rutland@arm.com> <1467907474-3290-4-git-send-email-mark.rutland@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1467907474-3290-4-git-send-email-mark.rutland@arm.com> User-Agent: Mutt/1.6.1 (2016-04-27) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.29]); Fri, 08 Jul 2016 07:55:18 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jul 07, 2016 at 05:04:34PM +0100, Mark Rutland wrote: > In systems with heterogeneous CPU PMUs, it's possible for each evsel to > cover a distinct set of CPUs, and hence the cpu_map associated with each > evsel may have a distinct idx<->id mapping. Any of these may be distinct from > the evlist's cpu map. > > Events can be tied to the same fd so long as they use the same per-cpu > ringbuffer (i.e. so long as they are on the same CPU). To acquire the > correct FDs, we must compare the Linux logical IDs rather than the evsel > or evlist indices. > > This path adds logic to perf_evlist__mmap_per_evsel to handle this, > translating IDs as required. As PMUs may cover a subset of CPUs from the > evlist, we skip the CPUs a PMU cannot handle. > > Signed-off-by: Mark Rutland > Cc: Adrian Hunter > Cc: Alexander Shishkin > Cc: Arnaldo Carvalho de Melo > Cc: He Kuang > Cc: Ingo Molnar > Cc: Jiri Olsa > Cc: Peter Zijlstra > Cc: Wang Nan > Cc: linux-kernel@vger.kernel.org > --- > tools/perf/util/evlist.c | 9 ++++++++- > 1 file changed, 8 insertions(+), 1 deletion(-) > > diff --git a/tools/perf/util/evlist.c b/tools/perf/util/evlist.c > index e82ba90..0b5b1be 100644 > --- a/tools/perf/util/evlist.c > +++ b/tools/perf/util/evlist.c > @@ -984,17 +984,24 @@ static int __perf_evlist__mmap(struct perf_evlist *evlist, int idx, > } > > static int perf_evlist__mmap_per_evsel(struct perf_evlist *evlist, int idx, > - struct mmap_params *mp, int cpu, > + struct mmap_params *mp, int cpu_idx, > int thread, int *output) > { > struct perf_evsel *evsel; > + int evlist_cpu = cpu_map__cpu(evlist->cpus, cpu_idx); > > evlist__for_each(evlist, evsel) { > int fd; > + int cpu; > > if (evsel->system_wide && thread) > continue; > > + if (!cpu_map__has(evsel->cpus, evlist_cpu)) > + continue; > + > + cpu = cpu_map__idx(evsel->cpus, evlist_cpu); you basicaly call cpu_map__idx twice in here, I think it might be better call it just once and check the cpu for -1 jirka