linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Frederic Weisbecker <fweisbec@gmail.com>
To: Ingo Molnar <mingo@kernel.org>
Cc: Rik van Riel <riel@redhat.com>,
	LKML <linux-kernel@vger.kernel.org>,
	Paolo Bonzini <pbonzini@redhat.com>,
	Peter Zijlstra <peterz@infradead.org>,
	rkrcmar@redhat.com, Thomas Gleixner <tglx@linutronix.de>,
	Mike Galbraith <efault@gmx.de>,
	wanpeng.li@hotmail.com
Subject: Re: [PATCH 0/2] sched/cputime: Deltas for "replace VTIME_GEN irq time code with IRQ_TIME_ACCOUNTING code"
Date: Fri, 8 Jul 2016 14:05:17 +0200	[thread overview]
Message-ID: <20160708120515.GC30200@lerouge> (raw)
In-Reply-To: <20160708120303.GA27634@gmail.com>

On Fri, Jul 08, 2016 at 02:03:03PM +0200, Ingo Molnar wrote:
> 
> * Frederic Weisbecker <fweisbec@gmail.com> wrote:
> 
> > On Fri, Jul 08, 2016 at 09:30:46AM +0200, Ingo Molnar wrote:
> > > 
> > > * Rik van Riel <riel@redhat.com> wrote:
> > > 
> > > > On Thu, 2016-07-07 at 16:27 +0200, Frederic Weisbecker wrote:
> > > > > Hi Rick,
> > > > > 
> > > > > While reviewing your 2nd patch, I thought about these cleanups.
> > > > > Perhaps
> > > > > the first one could be merged into your patch. I let you decide.
> > > > 
> > > > I'm not convinced we want to merge cleanups and functional
> > > > changes into the same patch, given how convoluted the code
> > > > is/was.
> > > > 
> > > > Both of your patches look good though.
> > > > 
> > > > What tree should they go in through?
> > > 
> > > -tip I suspect. So my plan was the following, this series of yours:
> > > 
> > >   [PATCH v3 0/4] sched,time: fix irq time accounting with nohz_idle
> > > 
> > > ... looked almost ready, it looked like as if I could merge v4 once you sent it.
> > > 
> > > Plus Frederic submitted these two cleanups - looks like I could merge these on top 
> > > of your series and have them close to each other in the Git space.
> > > 
> > > And I do agree that we should keep these cleanups separate and not merge them into 
> > > patches that change functionality.
> > > 
> > > If your series is expected to be risky then we could make things easier to handle 
> > > later on if we switched around things and first made low-risk cleanups and then 
> > > any changes/fixes on top - do you think that's necessary in this case?
> > 
> > I personally think that none of this is low-risk material. Perhaps we can gather 
> > the whole in the same tree? I can resend the series proper with my patches 
> > inside if you like. And I have yet to review the last patch of the series.
> 
> Sure, we can do it like that, for tip:timers/nohz.

Ok, I'll base it on tip:sched/core, right?

  reply	other threads:[~2016-07-08 12:05 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-07 14:27 [PATCH 0/2] sched/cputime: Deltas for "replace VTIME_GEN irq time code with IRQ_TIME_ACCOUNTING code" Frederic Weisbecker
2016-07-07 14:27 ` [PATCH 1/2] sched: Complete cleanup of old vtime gen irqtime accounting Frederic Weisbecker
2016-07-07 14:27 ` [PATCH 2/2] sched: Reorganize vtime native irqtime accounting headers Frederic Weisbecker
2016-07-07 16:11 ` [PATCH 0/2] sched/cputime: Deltas for "replace VTIME_GEN irq time code with IRQ_TIME_ACCOUNTING code" Rik van Riel
2016-07-08  7:30   ` Ingo Molnar
2016-07-08 11:17     ` Frederic Weisbecker
2016-07-08 12:03       ` Ingo Molnar
2016-07-08 12:05         ` Frederic Weisbecker [this message]
2016-07-08 12:21           ` Ingo Molnar
2016-07-08 12:36             ` Frederic Weisbecker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160708120515.GC30200@lerouge \
    --to=fweisbec@gmail.com \
    --cc=efault@gmx.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=pbonzini@redhat.com \
    --cc=peterz@infradead.org \
    --cc=riel@redhat.com \
    --cc=rkrcmar@redhat.com \
    --cc=tglx@linutronix.de \
    --cc=wanpeng.li@hotmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).