From: Baoquan He <bhe@redhat.com>
To: Ingo Molnar <mingo@kernel.org>
Cc: linux-kernel@vger.kernel.org,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Pavel Machek <pavel@ucw.cz>,
linux-acpi@vger.kernel.org, Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
Borislav Petkov <bp@suse.de>, Andy Lutomirski <luto@kernel.org>,
Shaohua Li <shli@fb.com>, Viresh Kumar <viresh.kumar@linaro.org>,
Hidehiro Kawai <hidehiro.kawai.ez@hitachi.com>,
Juergen Gross <jgross@suse.com>, Joerg Roedel <jroedel@suse.de>,
Dave Young <dyoung@redhat.com>, Lv Zheng <lv.zheng@intel.com>,
Toshi Kani <toshi.kani@hpe.com>, Mark Salter <msalter@redhat.com>,
Dave Hansen <dave.hansen@linux.intel.com>,
x86@kernel.org
Subject: Re: [PATCH v2 2/2] x86/acpi: Remove the repeated lapic address override entry parsing
Date: Fri, 8 Jul 2016 20:56:11 +0800 [thread overview]
Message-ID: <20160708125611.GC3125@x1.redhat.com> (raw)
In-Reply-To: <20160708122755.GA12413@gmail.com>
On 07/08/16 at 02:27pm, Ingo Molnar wrote:
>
> * Baoquan He <bhe@redhat.com> wrote:
>
> > ACPI MADT has a 32-bit field providing lapic address at which
> > each processor can access its lapic information. MADT also contains
> > an optional entry to provide a 64-bit address to override the 32-bit
> > one. However the current code does the lapic address override entry
> > parsing twice. One is in early_acpi_boot_init() because AMD NUMA need
> > get boot_cpu_id earlier. The other is in acpi_boot_init() which parses
> > all MADT entries.
> >
> > So in this patch remove the repeated code in the 2nd part. Meanwhile
> > print lapic override entry information like other MADT entry.
>
> So this patch is not supposed to change behavior (modulo kernel messages), right?
> If so it would make sense to spell that out explicitly in the changelog.
Yes, it won't. I will mention it in changelog and repost. Thanks for
your reviewing.
Thanks
Baoquan
next prev parent reply other threads:[~2016-07-08 12:56 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-27 23:41 [PATCH 1/2] x86/mm/numa: Open code function early_get_boot_cpu_id Baoquan He
2016-06-27 23:41 ` [PATCH 2/2] x86/acpi: Remove the repeated lapic address override entry parsing Baoquan He
2016-06-28 1:25 ` Rafael J. Wysocki
2016-06-28 3:30 ` Baoquan He
2016-06-30 8:01 ` [PATCH v2 " Baoquan He
2016-07-08 12:27 ` Ingo Molnar
2016-07-08 12:56 ` Baoquan He [this message]
2016-07-09 2:04 ` Baoquan He
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160708125611.GC3125@x1.redhat.com \
--to=bhe@redhat.com \
--cc=bp@suse.de \
--cc=dave.hansen@linux.intel.com \
--cc=dyoung@redhat.com \
--cc=hidehiro.kawai.ez@hitachi.com \
--cc=hpa@zytor.com \
--cc=jgross@suse.com \
--cc=jroedel@suse.de \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=lv.zheng@intel.com \
--cc=mingo@kernel.org \
--cc=mingo@redhat.com \
--cc=msalter@redhat.com \
--cc=pavel@ucw.cz \
--cc=rjw@rjwysocki.net \
--cc=shli@fb.com \
--cc=tglx@linutronix.de \
--cc=toshi.kani@hpe.com \
--cc=viresh.kumar@linaro.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).