From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754944AbcGHOS4 (ORCPT ); Fri, 8 Jul 2016 10:18:56 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:25849 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754868AbcGHOSs (ORCPT ); Fri, 8 Jul 2016 10:18:48 -0400 Date: Fri, 8 Jul 2016 10:17:37 -0400 From: Konrad Rzeszutek Wilk To: Jan Beulich Cc: david.vrabel@citrix.com, boris.ostrovsky@oracle.com, Juergen Gross , xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org Subject: Re: [Xen-devel] [PATCH v2 0/4] xen: prefer xenbus_scanf() over xenbus_gather() Message-ID: <20160708141737.GG22329@char.us.oracle.com> References: <577FB70002000078000FC9FA@prv-mh.provo.novell.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <577FB70002000078000FC9FA@prv-mh.provo.novell.com> User-Agent: Mutt/1.5.24 (2015-08-30) X-Source-IP: userv0021.oracle.com [156.151.31.71] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jul 08, 2016 at 06:21:52AM -0600, Jan Beulich wrote: > For single items being collected this should be preferred as being more > typesafe (as the compiler can check format string and to-be-written-to > variable match) and more efficient (requiring one less parameter to be > passed). > > 1: xenbus: prefer xenbus_scanf() over xenbus_gather() > 2: xen-blkback: prefer xenbus_scanf() over xenbus_gather() > 3: xen-blkfront: prefer xenbus_scanf() over xenbus_gather() > 4: xen-netback: prefer xenbus_scanf() over xenbus_gather() > > Signed-off-by: Jan Beulich > --- > v2: Avoid commit messages to continue from subjects. Group into a series. To confuse this, Roger and I are the block sub-maintainers, which when we are happy, I send to Jens, while the rest go through Boris,David, and Juergen. Anyhow, I've already committed and tested for regressions these: 79ef83a xen-blkback: constify instance of "struct attribute_group" 5e4d659 xen-blkfront: prefer xenbus_scanf() over xenbus_gather() e9d1ebe xen-blkback: prefer xenbus_scanf() over xenbus_gather() 5b3b1db xen-blkback: really don't leak mode property And plan to send them to Jens. They will shortly be at my git tree under 'stable/for-jens-4.8'. > > > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xen.org > https://lists.xen.org/xen-devel