From: Jiri Olsa <jolsa@redhat.com>
To: Wang Nan <wangnan0@huawei.com>
Cc: acme@kernel.org, lizefan@huawei.com,
linux-kernel@vger.kernel.org, pi3orama@163.com,
He Kuang <hekuang@huawei.com>,
Arnaldo Carvalho de Melo <acme@redhat.com>,
Jiri Olsa <jolsa@kernel.org>,
Masami Hiramatsu <mhiramat@kernel.org>,
Namhyung Kim <namhyung@kernel.org>,
Nilay Vaish <nilayvaish@gmail.com>
Subject: Re: [PATCH v14 4/8] perf record: Introduce rec->overwrite_evlist for overwritable events
Date: Fri, 8 Jul 2016 16:48:14 +0200 [thread overview]
Message-ID: <20160708144814.GB31763@krava> (raw)
In-Reply-To: <1467869689-214015-5-git-send-email-wangnan0@huawei.com>
On Thu, Jul 07, 2016 at 05:34:45AM +0000, Wang Nan wrote:
SNIP
> + if (err)
> + return err;
> +
> + err = record__mmap_evlist(rec, rec->evlist, false);
> + if (err)
> + return err;
> +
> + if (!rec->overwrite_evlist)
> + return 0;
> +
> + err = record__mmap_evlist(rec, rec->overwrite_evlist, true);
> + if (err)
> + return err;
> + return 0;
> }
>
> static int record__open(struct record *rec)
> @@ -698,9 +743,14 @@ static const struct perf_event_mmap_page *record__pick_pc(struct record *rec)
> {
> const struct perf_event_mmap_page *pc;
>
> + /* Change it to a loop if a new aux evlist is added */
> pc = perf_evlist__pick_pc(rec->evlist);
> if (pc)
> return pc;
> + pc = perf_evlist__pick_pc(rec->overwrite_evlist);
> + if (pc)
> + return pc;
> +
> return NULL;
above 4 lines could be just:
return perf_evlist__pick_pc(rec->overwrite_evlist);
jirka
next prev parent reply other threads:[~2016-07-08 14:48 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-07 5:34 [PATCH v14 0/8] perf tools: Support overwritable ring buffer Wang Nan
2016-07-07 5:34 ` [PATCH v14 1/8] perf tools: Drop redundant evsel->overwrite indicator Wang Nan
2016-07-07 5:34 ` [PATCH v14 2/8] perf evlist: Introduce aux evlist Wang Nan
2016-07-07 5:34 ` [PATCH v14 3/8] perf tests: Add testcase for auxiliary evlist Wang Nan
2016-07-08 14:48 ` Jiri Olsa
2016-07-08 14:48 ` Jiri Olsa
2016-07-08 14:48 ` Jiri Olsa
2016-07-11 3:20 ` Wangnan (F)
2016-07-07 5:34 ` [PATCH v14 4/8] perf record: Introduce rec->overwrite_evlist for overwritable events Wang Nan
2016-07-08 14:48 ` Jiri Olsa [this message]
2016-07-08 14:48 ` Jiri Olsa
2016-07-07 5:34 ` [PATCH v14 5/8] perf record: Read from overwritable ring buffer Wang Nan
2016-07-07 5:34 ` [PATCH v14 6/8] perf tools: Enable overwrite settings Wang Nan
2016-07-07 5:34 ` [PATCH v14 7/8] perf tools: Don't warn about out of order event if write_backward is used Wang Nan
2016-07-07 5:34 ` [PATCH v14 8/8] perf tools: Add --tail-synthesize option Wang Nan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160708144814.GB31763@krava \
--to=jolsa@redhat.com \
--cc=acme@kernel.org \
--cc=acme@redhat.com \
--cc=hekuang@huawei.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lizefan@huawei.com \
--cc=mhiramat@kernel.org \
--cc=namhyung@kernel.org \
--cc=nilayvaish@gmail.com \
--cc=pi3orama@163.com \
--cc=wangnan0@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox