From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755755AbcGHOsv (ORCPT ); Fri, 8 Jul 2016 10:48:51 -0400 Received: from mx1.redhat.com ([209.132.183.28]:45628 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755693AbcGHOsj (ORCPT ); Fri, 8 Jul 2016 10:48:39 -0400 Date: Fri, 8 Jul 2016 16:48:35 +0200 From: Jiri Olsa To: Wang Nan Cc: acme@kernel.org, lizefan@huawei.com, linux-kernel@vger.kernel.org, pi3orama@163.com, Arnaldo Carvalho de Melo , Jiri Olsa , Masami Hiramatsu , Namhyung Kim , Nilay Vaish , He Kuang Subject: Re: [PATCH v14 3/8] perf tests: Add testcase for auxiliary evlist Message-ID: <20160708144835.GE31763@krava> References: <1467869689-214015-1-git-send-email-wangnan0@huawei.com> <1467869689-214015-4-git-send-email-wangnan0@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1467869689-214015-4-git-send-email-wangnan0@huawei.com> User-Agent: Mutt/1.6.1 (2016-04-27) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Fri, 08 Jul 2016 14:48:39 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jul 07, 2016 at 05:34:44AM +0000, Wang Nan wrote: SNIP > } > diff --git a/tools/perf/util/evlist.h b/tools/perf/util/evlist.h > index 99bcc02..d736cd3 100644 > --- a/tools/perf/util/evlist.h > +++ b/tools/perf/util/evlist.h > @@ -149,6 +149,14 @@ union perf_event *perf_evlist__mmap_read_backward(struct perf_evlist *evlist, > int idx); > void perf_evlist__mmap_read_catchup(struct perf_evlist *evlist, int idx); > > +static inline void perf_evlist__mmap_read_catchup_all(struct perf_evlist *evlist) > +{ > + int i; > + > + for (i = 0; i < evlist->nr_mmaps; i++) > + perf_evlist__mmap_read_catchup(evlist, i); > +} any reason for this to be inline and not static within tests/backward-ring-buffer.c? thanks, jirka