From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755481AbcGHO4E (ORCPT ); Fri, 8 Jul 2016 10:56:04 -0400 Received: from mail-wm0-f66.google.com ([74.125.82.66]:33427 "EHLO mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754180AbcGHOz7 (ORCPT ); Fri, 8 Jul 2016 10:55:59 -0400 Date: Fri, 8 Jul 2016 16:55:55 +0200 From: Ingo Molnar To: Peter Zijlstra Cc: acme@kernel.org, linux-kernel@vger.kernel.org, andi@firstfloor.org, eranian@google.com, jolsa@kernel.org, torvalds@linux-foundation.org, davidcc@google.com, alexander.shishkin@linux.intel.com, namhyung@kernel.org, kan.liang@intel.com, khandual@linux.vnet.ibm.com Subject: Re: [RFC][PATCH 7/7] perf/annotate: Add branch stack / basic block information Message-ID: <20160708145555.GB17466@gmail.com> References: <20160708133059.031522978@infradead.org> <20160708134113.718203556@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160708134113.718203556@infradead.org> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Peter Zijlstra wrote: > $ perf record --branch-filter u,any -e cycles:p ./branches 27 > $ perf annotate branches Btw., I'd really like to use this feature all the time, so could we please simplify this somewhat via a subcommand, via something like: perf record branches ./branches 27 or if 'record' subcommands are not possible anymore: perf record --branches ./branches 27 and in this case 'perf annotate' should automatically pick up the fact that the perf.data was done with --branches - i.e. the highlighting should be automagic. I.e. the only thing a user has to remember to use all this is a single '--branches' option to perf record - instead of a complex sequence for perf record and another sequence for perf annotate. It would also be nice to have 'perf top --branches', with the built-in annotation showing the highlighted branch heat map information and highlighting. Thanks, Ingo