public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Jiri Olsa <jolsa@redhat.com>
To: Song Shan Gong <gongss@linux.vnet.ibm.com>
Cc: acme@kernel.org, jolsa@kernel.org, dsahern@gmail.com,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] [RFC V1]s390/perf: fix 'start' address of module's map
Date: Fri, 8 Jul 2016 17:18:36 +0200	[thread overview]
Message-ID: <20160708151836.GG31763@krava> (raw)
In-Reply-To: <1467856176-8712-1-git-send-email-gongss@linux.vnet.ibm.com>

On Thu, Jul 07, 2016 at 09:49:36AM +0800, Song Shan Gong wrote:
> At preset, when creating module's map, perf gets 'start' address by parsing
> 'proc/modules', but it's module base address, isn't the start address of
> '.text' section. In most archs, it's OK. But for s390, it places 'GOT' and
> 'PLT' relocations before '.text' section. So there exists an offset between
> module base address and '.text' section, which will incur wrong symbol
> resolution for modules.
> 
> Fix this bug by getting 'start' address of module's map from parsing
> '/sys/module/[module name]/sections/.text', not from '/proc/modules'.

cool, does this fix the 'perf test 1' for s390? that'd be great

I'll send few coments shortly

thanks,
jirka

  parent reply	other threads:[~2016-07-08 15:18 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-07  1:49 [PATCH] [RFC V1]s390/perf: fix 'start' address of module's map Song Shan Gong
2016-07-08  2:17 ` Songshan Gong
2016-07-08 15:20   ` Jiri Olsa
2016-07-08 15:18 ` Jiri Olsa [this message]
2016-07-11  8:11   ` Songshan Gong
2016-07-13  3:32     ` Songshan Gong
2016-07-08 15:20 ` Jiri Olsa
2016-07-08 15:21 ` Jiri Olsa
2016-07-08 15:21 ` Jiri Olsa
2016-07-11 11:06   ` Songshan Gong
2016-07-11 12:01     ` Jiri Olsa
2016-07-13  6:39       ` Songshan Gong
2016-07-13  9:07         ` Jiri Olsa
2016-07-15  7:45           ` Songshan Gong
2016-07-15  8:27             ` Jiri Olsa
2016-07-15 13:23               ` Arnaldo Carvalho de Melo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160708151836.GG31763@krava \
    --to=jolsa@redhat.com \
    --cc=acme@kernel.org \
    --cc=dsahern@gmail.com \
    --cc=gongss@linux.vnet.ibm.com \
    --cc=jolsa@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox