From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755754AbcGHP4F (ORCPT ); Fri, 8 Jul 2016 11:56:05 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:50189 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755087AbcGHPz5 (ORCPT ); Fri, 8 Jul 2016 11:55:57 -0400 Date: Fri, 8 Jul 2016 11:54:46 -0400 From: Konrad Rzeszutek Wilk To: David Vrabel Cc: Jan Beulich , boris.ostrovsky@oracle.com, Juergen Gross , xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org Subject: Re: [Xen-devel] [PATCH v2 0/4] xen: prefer xenbus_scanf() over xenbus_gather() Message-ID: <20160708155446.GA29604@char.us.oracle.com> References: <577FB70002000078000FC9FA@prv-mh.provo.novell.com> <20160708141737.GG22329@char.us.oracle.com> <577FC9A0.9080407@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <577FC9A0.9080407@citrix.com> User-Agent: Mutt/1.5.24 (2015-08-30) X-Source-IP: aserv0021.oracle.com [141.146.126.233] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jul 08, 2016 at 04:41:20PM +0100, David Vrabel wrote: > On 08/07/16 15:17, Konrad Rzeszutek Wilk wrote: > > On Fri, Jul 08, 2016 at 06:21:52AM -0600, Jan Beulich wrote: > >> For single items being collected this should be preferred as being more > >> typesafe (as the compiler can check format string and to-be-written-to > >> variable match) and more efficient (requiring one less parameter to be > >> passed). > >> > >> 1: xenbus: prefer xenbus_scanf() over xenbus_gather() > >> 2: xen-blkback: prefer xenbus_scanf() over xenbus_gather() > >> 3: xen-blkfront: prefer xenbus_scanf() over xenbus_gather() > >> 4: xen-netback: prefer xenbus_scanf() over xenbus_gather() > >> > >> Signed-off-by: Jan Beulich > >> --- > >> v2: Avoid commit messages to continue from subjects. Group into a series. > > > > To confuse this, Roger and I are the block sub-maintainers, which > > when we are happy, I send to Jens, while the rest go through Boris,David, and Juergen. > > > > Anyhow, I've already committed and tested for regressions these: > > 79ef83a xen-blkback: constify instance of "struct attribute_group" > > 5e4d659 xen-blkfront: prefer xenbus_scanf() over xenbus_gather() > > e9d1ebe xen-blkback: prefer xenbus_scanf() over xenbus_gather() > > 5b3b1db xen-blkback: really don't leak mode property > > If they're tree wide largely mechanical changes to Xen-related APIs I > prefer that they go via the Xen tree all together. > > This saves the submitter chasing the individual subsystem maintainers. Sure, but from a stricly SubmittingPatches point of view it would fall on your to get the Acks from the other maintainers. Either way, I am OK with those blkback and blkfront going through your tree, albeit one will conflict with Jens 'for-4.8/drivers'. > > David