From: Tejun Heo <tj@kernel.org>
To: Ming Lei <tom.leiming@gmail.com>
Cc: aaronlee0817 <aaronlee0817@163.com>, Jens Axboe <axboe@kernel.dk>,
Ming Lin <mlin@kernel.org>, Shaohua Li <shli@kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
cgroup@vger.kernel.org, jiale0817.li@samsung.com,
yanzi.zhang@samsung.com, zhen1.zhang@samsung.com,
linux-block <linux-block@vger.kernel.org>
Subject: Re: Re: cgroup: Fix split bio been throttled more than once
Date: Sat, 9 Jul 2016 10:53:21 -0400 [thread overview]
Message-ID: <20160709145321.GA3337@htj.duckdns.org> (raw)
In-Reply-To: <CACVXFVPW9TjTnUzAGRFu+mLhaoYTYLopTPvzJcRs85MmdVW=9A@mail.gmail.com>
Hello, Ming.
On Fri, Jul 08, 2016 at 06:35:06PM +0800, Ming Lei wrote:
> I am wondering why REQ_THROTTLED is cleared for the original bio
> even it has been charged and will be issued to driver, and is it allowed
> to throttle and charge the same bio for many times?
So, IIUC, the flag is just to prevent the bio from recursing while
being issued from blk-throtl after queued there for throttling. We
can probably extend the flag. I'm not sure how it'd interact with
stacked drivers tho. It'd definitely need to be cleared before
traveling down to a lower level device.
Thanks.
--
tejun
next prev parent reply other threads:[~2016-07-09 14:53 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-04 14:46 cgroup: Fix split bio been throttled more than once Jiale Li
2016-07-05 22:26 ` Tejun Heo
2016-07-06 1:14 ` Ming Lei
[not found] ` <458d1946.12fa6.155c0b80d60.Coremail.aaronlee0817@163.com>
2016-07-06 15:06 ` Tejun Heo
2016-07-06 15:39 ` Ming Lei
2016-07-06 1:10 ` Ming Lei
2016-07-06 14:09 ` Tejun Heo
2016-07-06 14:53 ` Ming Lei
[not found] ` <27824f6f.127ab.155c59d8a24.Coremail.aaronlee0817@163.com>
2016-07-08 10:35 ` Ming Lei
2016-07-09 14:53 ` Tejun Heo [this message]
2016-07-10 8:58 ` Ming Lei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160709145321.GA3337@htj.duckdns.org \
--to=tj@kernel.org \
--cc=aaronlee0817@163.com \
--cc=axboe@kernel.dk \
--cc=cgroup@vger.kernel.org \
--cc=jiale0817.li@samsung.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mlin@kernel.org \
--cc=shli@kernel.org \
--cc=tom.leiming@gmail.com \
--cc=yanzi.zhang@samsung.com \
--cc=zhen1.zhang@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).