From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933253AbcGJByx (ORCPT ); Sat, 9 Jul 2016 21:54:53 -0400 Received: from mail-pf0-f193.google.com ([209.85.192.193]:34777 "EHLO mail-pf0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932100AbcGJByw (ORCPT ); Sat, 9 Jul 2016 21:54:52 -0400 Date: Sat, 9 Jul 2016 18:54:48 -0700 From: Brian Norris To: Denys Vlasenko Cc: David Woodhouse , Dan Carpenter , Artem Bityutskiy , linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] drivers/mtd/chips/cfi_cmdset_0020.c: Deinline do_write_buffer, save 5316 bytes Message-ID: <20160710015448.GC7547@localhost> References: <1460140543-12487-1-git-send-email-dvlasenk@redhat.com> <1460140543-12487-3-git-send-email-dvlasenk@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1460140543-12487-3-git-send-email-dvlasenk@redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Apr 08, 2016 at 08:35:43PM +0200, Denys Vlasenko wrote: > This function compiles to 2554 bytes of machine code. > In C, the function is almost 200 lines long. > > It has only one callsite, but forced inlining that much code > makes gcc generate significantly worse code. Let gcc itself decide > what to do. > > Signed-off-by: Denys Vlasenko > CC: David Woodhouse > CC: Brian Norris > CC: Dan Carpenter > CC: Artem Bityutskiy > CC: linux-mtd@lists.infradead.org > CC: linux-kernel@vger.kernel.org Applied to l2-mtd.git