From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757098AbcGJLYh (ORCPT ); Sun, 10 Jul 2016 07:24:37 -0400 Received: from mail-wm0-f49.google.com ([74.125.82.49]:38538 "EHLO mail-wm0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750904AbcGJLYd (ORCPT ); Sun, 10 Jul 2016 07:24:33 -0400 Date: Sun, 10 Jul 2016 13:24:27 +0200 From: Ingo Molnar To: Baoquan He Cc: peterz@infradead.org, hpa@zytor.com, keescook@chromium.org, xiaolong.ye@intel.com, linux-kernel@vger.kernel.org, tglx@linutronix.de, torvalds@linux-foundation.org, linux-tip-commits@vger.kernel.org Subject: Re: [tip:x86/boot] x86/KASLR: Fix boot crash with certain memory configurations Message-ID: <20160710112427.GA16729@gmail.com> References: <20160710090953.GA2512@x1.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160710090953.GA2512@x1.redhat.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Baoquan He wrote: > Hi Ingo, > > I am sorry the previous post didn't contain formal patch log. I made a new one > as below. The boot crash could not only happen with certain memory. Because of > this code bug the regions which need be avoided like the zipped kernel with its > unzipping running code, initrd, kernel command line could be corrupted if > mem_avoid_overlap() can't find the overlap region with the lowest address. But > it's very lucky that Xiaolong's system which has only 300M memory can always > reproduce it. I checked the boog log and found on his system no any other slot > can be chosen except for the original one. If we have a system with large memory > it may not be easy to hit it, at least with low probability since there are many > candidate slots. So if it's just a better changelog that what I wrote I wouldn't rebase the commit: there's other commits on top of the fix meanwhile. Should a rebase become necessary at a later point I'll update it with your extended changelog. Thanks, Ingo