From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758477AbcGKKlT (ORCPT ); Mon, 11 Jul 2016 06:41:19 -0400 Received: from mail.us.es ([193.147.175.20]:54210 "EHLO mail.us.es" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758369AbcGKKlR (ORCPT ); Mon, 11 Jul 2016 06:41:17 -0400 Date: Mon, 11 Jul 2016 12:41:10 +0200 From: Pablo Neira Ayuso To: Eric Engestrom Cc: linux-kernel@vger.kernel.org, Eric Engestrom , Patrick McHardy , Jozsef Kadlecsik , netfilter-devel@vger.kernel.org, coreteam@netfilter.org Subject: Re: [PATCH 2/2] netfilter: add missing macro Message-ID: <20160711104110.GA1540@salvia> References: <20160708162911.18756-1-eric.engestrom@imgtec.com> <20160708162911.18756-2-eric.engestrom@imgtec.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20160708162911.18756-2-eric.engestrom@imgtec.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jul 08, 2016 at 05:29:11PM +0100, Eric Engestrom wrote: > Signed-off-by: Eric Engestrom > --- > > This can't compile without this macro… Is this header really used by anyone? > Should it be removed, to avoid bit-rot? Probably better to define something like: #define SCTP_BITMAP_LEN (256 / sizeof (u_int32_t)) and use it consistently all around the code, so we can get rid of these ARRAY_SIZE() from the uapi header. > --- > include/uapi/linux/netfilter/xt_sctp.h | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/include/uapi/linux/netfilter/xt_sctp.h b/include/uapi/linux/netfilter/xt_sctp.h > index 58ffcfb..e4410db 100644 > --- a/include/uapi/linux/netfilter/xt_sctp.h > +++ b/include/uapi/linux/netfilter/xt_sctp.h > @@ -3,6 +3,8 @@ > > #include > > +#define ARRAY_SIZE(arr) (sizeof(arr) / sizeof(arr)[0]) > + > #define XT_SCTP_SRC_PORTS 0x01 > #define XT_SCTP_DEST_PORTS 0x02 > #define XT_SCTP_CHUNK_TYPES 0x04 > -- > 2.9.0 >