From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1758403AbcGKKug (ORCPT <rfc822;w@1wt.eu>);
	Mon, 11 Jul 2016 06:50:36 -0400
Received: from foss.arm.com ([217.140.101.70]:52110 "EHLO foss.arm.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752823AbcGKKuf (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Mon, 11 Jul 2016 06:50:35 -0400
Date: Mon, 11 Jul 2016 11:50:23 +0100
From: Mark Rutland <mark.rutland@arm.com>
To: Jiri Olsa <jolsa@redhat.com>
Cc: linux-kernel@vger.kernel.org, acme@kernel.org, adrian.hunter@intel.com,
        alexander.shishkin@linux.intel.com, hekuang@huawei.com,
        jolsa@kernel.org, kan.liang@intel.com, mingo@redhat.com,
        peterz@infradead.org, wangnan0@huawei.com
Subject: Re: [RFC PATCH 3/3] perf: util: only open events on CPUs an evsel
 permits
Message-ID: <20160711105022.GE31221@leverpostej>
References: <1467907474-3290-1-git-send-email-mark.rutland@arm.com>
 <1467907474-3290-4-git-send-email-mark.rutland@arm.com>
 <20160708075514.GA26532@krava>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20160708075514.GA26532@krava>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Jul 08, 2016 at 09:55:14AM +0200, Jiri Olsa wrote:
> On Thu, Jul 07, 2016 at 05:04:34PM +0100, Mark Rutland wrote:
> > +		if (!cpu_map__has(evsel->cpus, evlist_cpu))
> > +			continue;
> > +
> > +		cpu = cpu_map__idx(evsel->cpus, evlist_cpu);
> 
> you basicaly call cpu_map__idx twice in here,
> I think it might be better call it just once
> and check the cpu for -1

Sure, I can change the patch to do that.

Mark.