From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933717AbcGKMB7 (ORCPT ); Mon, 11 Jul 2016 08:01:59 -0400 Received: from mx1.redhat.com ([209.132.183.28]:54941 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751404AbcGKMB6 (ORCPT ); Mon, 11 Jul 2016 08:01:58 -0400 Date: Mon, 11 Jul 2016 14:01:55 +0200 From: Jiri Olsa To: Songshan Gong Cc: acme@kernel.org, jolsa@kernel.org, dsahern@gmail.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH] [RFC V1]s390/perf: fix 'start' address of module's map Message-ID: <20160711120155.GA29929@krava> References: <1467856176-8712-1-git-send-email-gongss@linux.vnet.ibm.com> <20160708152133.GK31763@krava> <657df05c-c0d9-7490-d374-f2fa4cdd7344@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <657df05c-c0d9-7490-d374-f2fa4cdd7344@linux.vnet.ibm.com> User-Agent: Mutt/1.6.1 (2016-04-27) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.25]); Mon, 11 Jul 2016 12:01:58 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jul 11, 2016 at 07:06:14PM +0800, Songshan Gong wrote: SNIP > > > > we have following functions in tools/lib/api/fs to read > > single number from file, which I assume you do above: > > > > int sysfs__read_int(const char *entry, int *value); > > int sysfs__read_ull(const char *entry, unsigned long long *value); > > > > please check if you could use some of them, > > we could add some more generic one if needed > > It seems infeasible. > Each value in /sys/module/[module name]/sections/.text is a string like > "0x000003ff8130078\n". > But the core function 'strtoull(line, NULL, 10)' in sysfs__read_ull is based > on decimal. > > Maybe you can introduce a new argument indicating the value is based on hex > or decimal, or binary? yea we could specify it directly and add something like: int filename__read_ull(const char *filename, unsigned long long *value, int base) plus some other higher layer helpers.. but I wonder if we could use the base 0 (like in the attached patch), the man page says it should be able to detect the base we'd need to check all the current usage to make sure nothing gets broken jirka --- diff --git a/tools/lib/api/fs/fs.c b/tools/lib/api/fs/fs.c index 08556cf2c70d..d18ae548468a 100644 --- a/tools/lib/api/fs/fs.c +++ b/tools/lib/api/fs/fs.c @@ -292,7 +292,7 @@ int filename__read_ull(const char *filename, unsigned long long *value) return -1; if (read(fd, line, sizeof(line)) > 0) { - *value = strtoull(line, NULL, 10); + *value = strtoull(line, NULL, 0); if (*value != ULLONG_MAX) err = 0; }