From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759041AbcGKOeh (ORCPT ); Mon, 11 Jul 2016 10:34:37 -0400 Received: from mail-wm0-f65.google.com ([74.125.82.65]:33851 "EHLO mail-wm0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759022AbcGKOef (ORCPT ); Mon, 11 Jul 2016 10:34:35 -0400 Date: Mon, 11 Jul 2016 16:34:24 +0200 From: Ingo Molnar To: Anna-Maria Gleixner Cc: LKML , Peter Zijlstra , Richard Cochran , Sebastian Andrzej Siewior , Jason Cooper , Marc Zyngier Subject: Re: [patch 02/66] irqchip/gic: Convert to hotplug state machine Message-ID: <20160711143424.GA20760@gmail.com> References: <20160711122450.923603742@linutronix.de> <20160711122530.756245275@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160711122530.756245275@linutronix.de> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Anna-Maria Gleixner wrote: > More or less straightforward, although this driver sports some very > interesting SMP setup code. Regarding the callback ordering, this > deleted comment is interesting: > > ... the GIC needs to be up before the ARM generic timers. > > That comment is half baken as the same requirement is true for perf. > > Signed-off-by: Richard Cochran > Reviewed-by: Sebastian Andrzej Siewior > Cc: Jason Cooper > Cc: Marc Zyngier > Signed-off-by: Anna-Maria Gleixner The SOB sequence is unusal. Is this patch missing this line: From: Richard Cochran ... or should the SOB be: Acked-by: Richard Cochran ? Thanks, Ingo