From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030821AbcGKRD1 (ORCPT ); Mon, 11 Jul 2016 13:03:27 -0400 Received: from mail-pa0-f41.google.com ([209.85.220.41]:35576 "EHLO mail-pa0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1030774AbcGKRDZ (ORCPT ); Mon, 11 Jul 2016 13:03:25 -0400 Date: Mon, 11 Jul 2016 10:03:21 -0700 From: "'Dmitry Torokhov'" To: =?utf-8?B?5buW5bSH5qau?= Cc: "'KT Liao'" , linux-kernel@vger.kernel.org, linux-input@vger.kernel.org, phoenix@emc.com.tw Subject: Re: [PATCH] Input: /input/mouse/elan_i2c_core.c Fix some Asus touchapod which casue TP no funciton sometimes, the patch detect some specific touchpad and run a special initialize Message-ID: <20160711170321.GB26822@dtor-ws> References: <1467979929-3409-1-git-send-email-kt.liao@emc.com.tw> <20160709002448.GI28589@dtor-ws> <019201d1db71$7986cd80$6c946880$@emc.com.tw> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <019201d1db71$7986cd80$6c946880$@emc.com.tw> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jul 11, 2016 at 08:40:58PM +0800, 廖崇榮 wrote: > > + > > + error = data->ops->get_sm_version(client, &data->ic_type, > > + &data->sm_version); > > + if (error) > > + return false; > > That means we'd be fetching product ID and IC type twice when initializing the device. Can we come with a way to do it once? > [KT]:Because the elan_query_device_info() is behind the elan_initialize(). That's why I fetching product ID and IC type in the elan_initialize() > I will discuss with FW team and then execute elan_query_device_info() first to get product_id and ic_type. We might need to split fetching product ID and IC type form the rest of the device info. Thanks. -- Dmitry