From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753394AbcGKVXo (ORCPT ); Mon, 11 Jul 2016 17:23:44 -0400 Received: from down.free-electrons.com ([37.187.137.238]:54045 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751157AbcGKVXm (ORCPT ); Mon, 11 Jul 2016 17:23:42 -0400 Date: Mon, 11 Jul 2016 23:23:40 +0200 From: Alexandre Belloni To: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= Cc: Stephen Rothwell , linux-next@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: linux-next: build warning after merge of the rtc tree Message-ID: <20160711212340.GS22202@piout.net> References: <20160711181208.2d60493a@canb.auug.org.au> <20160711082351.GA10303@perseus.defre.kleine-koenig.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20160711082351.GA10303@perseus.defre.kleine-koenig.org> User-Agent: Mutt/1.6.0 (2016-04-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/07/2016 at 10:23:51 +0200, Uwe Kleine-König wrote : > Hello, > > On Mon, Jul 11, 2016 at 06:12:08PM +1000, Stephen Rothwell wrote: > > After merging the rtc tree, today's linux-next build (x86 64_allmodconfig) > > produced this warning: > > > > drivers/rtc/rtc-isl12057.c: In function 'isl12057_rtc_read_alarm': > > drivers/rtc/rtc-isl12057.c:249:26: warning: unused variable 'alarm_secs' [-Wunused-variable] > > unsigned long rtc_secs, alarm_secs; > > ^ > > drivers/rtc/rtc-isl12057.c:249:16: warning: unused variable 'rtc_secs' [-Wunused-variable] > > unsigned long rtc_secs, alarm_secs; > > ^ > > drivers/rtc/rtc-isl12057.c:248:18: warning: unused variable 'rtc_tm' [-Wunused-variable] > > struct rtc_time rtc_tm, *alarm_tm = &alarm->time; > > ^ > > > > Introduced by commit > > > > 4e30a585a343 ("rtc: isl12057: let the rtc core interpret the partial alarm") > > Thanks for catching that. The obvious fix is: > > diff --git a/drivers/rtc/rtc-isl12057.c b/drivers/rtc/rtc-isl12057.c > index e0245fc6205e..0e7f0f52bfe4 100644 > --- a/drivers/rtc/rtc-isl12057.c > +++ b/drivers/rtc/rtc-isl12057.c > @@ -245,8 +245,7 @@ static int isl12057_rtc_update_alarm(struct device *dev, int enable) > static int isl12057_rtc_read_alarm(struct device *dev, struct rtc_wkalrm *alarm) > { > struct isl12057_rtc_data *data = dev_get_drvdata(dev); > - struct rtc_time rtc_tm, *alarm_tm = &alarm->time; > - unsigned long rtc_secs, alarm_secs; > + struct rtc_time *alarm_tm = &alarm->time; > u8 regs[ISL12057_A1_SEC_LEN]; > unsigned int ir; > int ret; > > Alexandre: Do you fixup, or should I send a proper patch for that? > I fixed it up. I shouldn't have missed that one... -- Alexandre Belloni, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com