From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752662AbcGKWkE (ORCPT ); Mon, 11 Jul 2016 18:40:04 -0400 Received: from mail-pa0-f53.google.com ([209.85.220.53]:32935 "EHLO mail-pa0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751214AbcGKWkC (ORCPT ); Mon, 11 Jul 2016 18:40:02 -0400 Date: Mon, 11 Jul 2016 17:39:58 -0500 From: Andy Gross To: Stephen Boyd Cc: Mark Brown , linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Bjorn Andersson Subject: Re: [PATCH 3/3] regulator: qcom_smd: Avoid overlapping linear voltage ranges Message-ID: <20160711223958.GB6053@hector.attlocal.net> References: <20160711215009.4519-1-sboyd@codeaurora.org> <20160711215009.4519-4-sboyd@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160711215009.4519-4-sboyd@codeaurora.org> User-Agent: Mutt/1.5.23.1 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jul 11, 2016 at 02:50:09PM -0700, Stephen Boyd wrote: > The pm8x41_hfsmps ranges overlap. The first range is from 375000 > to 1562500: > > 375000 + (95 * 12500) == 1562500 > > and the second range starts at 1550000. Interestingly, the second > range ends at the correct value when it's set to be the > appropriate start value, 1575000: > > 1575000 + ((158 - 96) * 25000) == 3125000 > > Cc: Andy Gross > Cc: Bjorn Andersson > Fixes: da65e367b67e ("regulator: Regulator driver for the Qualcomm RPM") > Signed-off-by: Stephen Boyd > --- Reviewed-by: Andy Gross