From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030333AbcGLO6U (ORCPT ); Tue, 12 Jul 2016 10:58:20 -0400 Received: from gum.cmpxchg.org ([85.214.110.215]:51802 "EHLO gum.cmpxchg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1030249AbcGLO6S (ORCPT ); Tue, 12 Jul 2016 10:58:18 -0400 Date: Tue, 12 Jul 2016 10:58:01 -0400 From: Johannes Weiner To: Mel Gorman Cc: Andrew Morton , Linux-MM , Rik van Riel , Vlastimil Babka , Minchan Kim , Joonsoo Kim , LKML Subject: Re: [PATCH 18/34] mm: rename NR_ANON_PAGES to NR_ANON_MAPPED Message-ID: <20160712145801.GJ5881@cmpxchg.org> References: <1467970510-21195-1-git-send-email-mgorman@techsingularity.net> <1467970510-21195-19-git-send-email-mgorman@techsingularity.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1467970510-21195-19-git-send-email-mgorman@techsingularity.net> User-Agent: Mutt/1.6.1 (2016-04-27) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jul 08, 2016 at 10:34:54AM +0100, Mel Gorman wrote: > NR_FILE_PAGES is the number of file pages. > NR_FILE_MAPPED is the number of mapped file pages. > NR_ANON_PAGES is the number of mapped anon pages. > > This is unhelpful naming as it's easy to confuse NR_FILE_MAPPED and > NR_ANON_PAGES for mapped pages. This patch renames NR_ANON_PAGES so we > have > > NR_FILE_PAGES is the number of file pages. > NR_FILE_MAPPED is the number of mapped file pages. > NR_ANON_MAPPED is the number of mapped anon pages. That looks wrong to me. The symmetry is between NR_FILE_PAGES and NR_ANON_PAGES. NR_FILE_MAPPED is merely elaborating on the mapped subset of NR_FILE_PAGES, something which isn't necessary for anon pages as they're always mapped.