From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754980AbcGLPQC (ORCPT <rfc822;w@1wt.eu>);
	Tue, 12 Jul 2016 11:16:02 -0400
Received: from gum.cmpxchg.org ([85.214.110.215]:51842 "EHLO gum.cmpxchg.org"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1754194AbcGLPQA (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Tue, 12 Jul 2016 11:16:00 -0400
Date: Tue, 12 Jul 2016 11:15:37 -0400
From: Johannes Weiner <hannes@cmpxchg.org>
To: Mel Gorman <mgorman@techsingularity.net>
Cc: Andrew Morton <akpm@linux-foundation.org>, Linux-MM <linux-mm@kvack.org>,
        Rik van Riel <riel@surriel.com>, Vlastimil Babka <vbabka@suse.cz>,
        Minchan Kim <minchan@kernel.org>, Joonsoo Kim <iamjoonsoo.kim@lge.com>,
        LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 20/34] mm: move vmscan writes and file write accounting
 to the node
Message-ID: <20160712151537.GL5881@cmpxchg.org>
References: <1467970510-21195-1-git-send-email-mgorman@techsingularity.net>
 <1467970510-21195-21-git-send-email-mgorman@techsingularity.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1467970510-21195-21-git-send-email-mgorman@techsingularity.net>
User-Agent: Mutt/1.6.1 (2016-04-27)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Jul 08, 2016 at 10:34:56AM +0100, Mel Gorman wrote:
> As reclaim is now node-based, it follows that page write activity due to
> page reclaim should also be accounted for on the node.  For consistency,
> also account page writes and page dirtying on a per-node basis.
> 
> After this patch, there are a few remaining zone counters that may appear
> strange but are fine.  NUMA stats are still per-zone as this is a
> user-space interface that tools consume.  NR_MLOCK, NR_SLAB_*,
> NR_PAGETABLE, NR_KERNEL_STACK and NR_BOUNCE are all allocations that
> potentially pin low memory and cannot trivially be reclaimed on demand.
> This information is still useful for debugging a page allocation failure
> warning.
> 
> Signed-off-by: Mel Gorman <mgorman@techsingularity.net>
> Acked-by: Vlastimil Babka <vbabka@suse.cz>
> Acked-by: Michal Hocko <mhocko@suse.com>

More conversion... ;) FWIW, I didn't spot anything problematic. And
agreed with leaving unmovable stuff counters on a per-zone basis.

Acked-by: Johannes Weiner <hannes@cmpxchg.org>