From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755097AbcGLP0n (ORCPT ); Tue, 12 Jul 2016 11:26:43 -0400 Received: from bombadil.infradead.org ([198.137.202.9]:37945 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754807AbcGLP0m (ORCPT ); Tue, 12 Jul 2016 11:26:42 -0400 Date: Tue, 12 Jul 2016 17:26:40 +0200 From: Peter Zijlstra To: Xunlei Pang Cc: linux-kernel@vger.kernel.org, Ingo Molnar , Konstantin Khlebnikov Subject: Re: [PATCH] sched/fair: Fix the misuse of cfs_rq in sync_throttle() Message-ID: <20160712152640.GW30909@twins.programming.kicks-ass.net> References: <1468050862-18864-1-git-send-email-xlpang@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1468050862-18864-1-git-send-email-xlpang@redhat.com> User-Agent: Mutt/1.5.23.1 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Jul 09, 2016 at 03:54:22PM +0800, Xunlei Pang wrote: > +++ b/kernel/sched/fair.c > @@ -4269,7 +4269,7 @@ static void sync_throttle(struct task_group *tg, int cpu) > pcfs_rq = tg->parent->cfs_rq[cpu]; > > cfs_rq->throttle_count = pcfs_rq->throttle_count; > - pcfs_rq->throttled_clock_task = rq_clock_task(cpu_rq(cpu)); > + cfs_rq->throttled_clock_task = rq_clock_task(cpu_rq(cpu)); Ah indeed, thanks! > } > > /* conditionally throttle active cfs_rq's from put_prev_entity() */ > -- > 1.8.3.1 >