From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1751455AbcGLT1X (ORCPT <rfc822;w@1wt.eu>);
	Tue, 12 Jul 2016 15:27:23 -0400
Received: from mail.kernel.org ([198.145.29.136]:36248 "EHLO mail.kernel.org"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1750885AbcGLT1V (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Tue, 12 Jul 2016 15:27:21 -0400
Date: Tue, 12 Jul 2016 16:27:16 -0300
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Jiri Olsa <jolsa@redhat.com>, Jiri Olsa <jolsa@kernel.org>,
        lkml <linux-kernel@vger.kernel.org>, David Ahern <dsahern@gmail.com>,
        Ingo Molnar <mingo@kernel.org>, Namhyung Kim <namhyung@kernel.org>,
        Peter Zijlstra <a.p.zijlstra@chello.nl>
Subject: Re: [PATCH 10/10] perf script python: Fix string vs byte array
 resolving
Message-ID: <20160712192716.GH3387@kernel.org>
References: <1468148882-10362-1-git-send-email-jolsa@kernel.org>
 <1468148882-10362-11-git-send-email-jolsa@kernel.org>
 <20160711115452.02ba1d6c@gandalf.local.home>
 <20160712081156.GB3392@krava>
 <20160712083728.2c468986@gandalf.local.home>
 <20160712125245.GA20585@krava>
 <20160712090001.0e8cdb6d@gandalf.local.home>
 <20160712133552.GA30438@krava>
 <20160712094836.0069bc20@gandalf.local.home>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20160712094836.0069bc20@gandalf.local.home>
X-Url: http://acmel.wordpress.com
User-Agent: Mutt/1.6.1 (2016-04-27)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Em Tue, Jul 12, 2016 at 09:48:36AM -0400, Steven Rostedt escreveu:
> On Tue, 12 Jul 2016 15:35:52 +0200
> Jiri Olsa <jolsa@redhat.com> wrote:
> 
> > On Tue, Jul 12, 2016 at 09:00:01AM -0400, Steven Rostedt wrote:
> > > On Tue, 12 Jul 2016 14:52:45 +0200
> > > Jiri Olsa <jolsa@redhat.com> wrote:
> > > 
> > >   
> > > > hum, so string is not passed to trace buffer with 0 at the end?  
> > > 
> > > strlen() returns only the length of the string (minus the \0 at the
> > > end).  
> > 
> > yea, is_printable_array is called here on tracepoint
> > data that's why I asked.. is 0 part of the string data
> > when stored within tracepoint?
> 
> Good question. It may or may not (haven't looked at the code), but we
> probably want to make sure that the function is robust enough for
> either case.

Ok, applied and tested up to patch 9, waiting for this discussion to
come to an end to consider 10.

- Arnaldo
 
> > 
> > >   
> > > > 
> > > > I'll check the option of passing everything as PyByteArray.
> > > > If it's the same for user, we'll have simpler code in here.
> > > >   
> > > > > 
> > > > > because the last byte wont be 0. What about:
> > > > > 
> > > > > 	for (i = 0; i < len; i++)
> > > > > 		if (!isprint(p[i]) && !isspace(p[i]))
> > > > > 			break;
> > > > > 
> > > > > 	return i == len ||
> > > > > 		(i == len - 1 && p[i] == 0);    
> > > 
> > > Or you can do:
> > > 
> > > 	if (p[len - 1] == 0)
> > > 		len--;
> > > 
> > > 	for (i = 0; i < len; i++)
> > > 		if (!isprint(p[i]) && !isspace(p[i]))
> > > 			return 0;
> > > 	return 1;  
> > 
> > yep, seems good.. thanks
> > 
> 
> OK, great!
> 
> -- Steve