From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751074AbcGMGYY (ORCPT ); Wed, 13 Jul 2016 02:24:24 -0400 Received: from mail-wm0-f43.google.com ([74.125.82.43]:38171 "EHLO mail-wm0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751114AbcGMGYQ (ORCPT ); Wed, 13 Jul 2016 02:24:16 -0400 Date: Wed, 13 Jul 2016 08:23:58 +0200 From: =?UTF-8?B?TWljaGHFgg==?= Pecio To: Cc: , , , , Subject: Re: [PATCH v6 RESEND] r8152: Add support for setting pass through MAC address on RTL8153-AD Message-ID: <20160713082358.487082a4@sauron> In-Reply-To: <5a304b784fe747aea4de6b69fb12a767@ausx13mpc124.AMER.DELL.COM> References: <1468285084-26557-1-git-send-email-mario_limonciello@dell.com> <20160711.194246.742914205682079488.davem@davemloft.net> <20160712090248.7b5633e5@sauron> <5a304b784fe747aea4de6b69fb12a767@ausx13mpc124.AMER.DELL.COM> X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.30; x86_64-unknown-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > So in order to hit this hypothetical corner case today you would > need to be using a real world type-C device something such as a > Dell WD15 on another OEM's machine that has type-C and the exact > same ACPI object name that does $BADSTUFF other than return a > buffer. Exactly what I meant. > If that situation arises please alert me and I'll send a follow up > patch that whitelists this to match DMI vendor of only Dell > systems. I'm not sure if it's the most responsible way to approach this problem. There were cases of laptops bricking (as in - they would never power on ever again) just because Linux made some bad BIOS/ACPI calls. Also, see the famous Samsung UEFI NVRAM fiasco or the recent pains with EFIVARS. Regards, MP