From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751174AbcGMM3o (ORCPT ); Wed, 13 Jul 2016 08:29:44 -0400 Received: from gum.cmpxchg.org ([85.214.110.215]:52250 "EHLO gum.cmpxchg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750883AbcGMM3i (ORCPT ); Wed, 13 Jul 2016 08:29:38 -0400 Date: Wed, 13 Jul 2016 08:28:48 -0400 From: Johannes Weiner To: Mel Gorman Cc: Andrew Morton , Linux-MM , Rik van Riel , Vlastimil Babka , Minchan Kim , Joonsoo Kim , LKML Subject: Re: [PATCH 12/34] mm: vmscan: do not reclaim from kswapd if there is any eligible zone Message-ID: <20160713122848.GA9905@cmpxchg.org> References: <1467970510-21195-1-git-send-email-mgorman@techsingularity.net> <1467970510-21195-13-git-send-email-mgorman@techsingularity.net> <20160712142909.GF5881@cmpxchg.org> <20160713084742.GG9806@techsingularity.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160713084742.GG9806@techsingularity.net> User-Agent: Mutt/1.6.1 (2016-04-27) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jul 13, 2016 at 09:47:42AM +0100, Mel Gorman wrote: > On Tue, Jul 12, 2016 at 10:29:09AM -0400, Johannes Weiner wrote: > > > + /* > > > + * If the number of buffer_heads in the machine exceeds the > > > + * maximum allowed level then reclaim from all zones. This is > > > + * not specific to highmem as highmem may not exist but it is > > > + * it is expected that buffer_heads are stripped in writeback. > > > > The mention of highmem in this comment make only sense within the > > context of this diff; it'll be pretty confusing in the standalone > > code. > > > > Also, double "it is" :) > > Is this any better? Yes, this is great! Thank you. > Note that it's marked as a fix to a later patch to reduce collisions in > mmotm. It's not a bisection risk so I saw little need to cause > unnecessary conflicts for Andrew. That seems completely reasonable to me. > ---8<--- > mm, vmscan: Have kswapd reclaim from all zones if reclaiming and buffer_heads_over_limit -fix > > Johannes reported that the comment about buffer_heads_over_limit in > balance_pgdat only made sense in the context of the patch. This > patch clarifies the reasoning and how it applies to 32 and 64 bit > systems. > > This is a fix to the mmotm patch > mm-vmscan-have-kswapd-reclaim-from-all-zones-if-reclaiming-and-buffer_heads_over_limit.patch > > Suggested-by: Johannes Weiner > Signed-off-by: Mel Gorman Acked-by: Johannes Weiner