From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753006AbcGMOH0 (ORCPT <rfc822;w@1wt.eu>);
	Wed, 13 Jul 2016 10:07:26 -0400
Received: from mx1.redhat.com ([209.132.183.28]:59501 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751214AbcGMOHV (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Wed, 13 Jul 2016 10:07:21 -0400
Date: Wed, 13 Jul 2016 16:06:37 +0200
From: Jiri Olsa <jolsa@redhat.com>
To: Wang Nan <wangnan0@huawei.com>
Cc: acme@kernel.org, lizefan@huawei.com, linux-kernel@vger.kernel.org,
        pi3orama@163.com, Arnaldo Carvalho de Melo <acme@redhat.com>,
        He Kuang <hekuang@huawei.com>, Jiri Olsa <jolsa@kernel.org>,
        Masami Hiramatsu <mhiramat@kernel.org>,
        Namhyung Kim <namhyung@kernel.org>, Nilay Vaish <nilayvaish@gmail.com>
Subject: Re: [PATCH v15 03/12] perf tools: Update perf evlist mmap related
 APIs and helpers
Message-ID: <20160713140637.GB31742@krava>
References: <1468317612-11598-1-git-send-email-wangnan0@huawei.com>
 <1468317612-11598-4-git-send-email-wangnan0@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1468317612-11598-4-git-send-email-wangnan0@huawei.com>
User-Agent: Mutt/1.6.2 (2016-07-01)
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.26]); Wed, 13 Jul 2016 14:06:41 +0000 (UTC)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Jul 12, 2016 at 10:00:03AM +0000, Wang Nan wrote:

SNIP

> -union perf_event *perf_evlist__mmap_read_forward(struct perf_evlist *evlist, int idx)
> +union perf_event *perf_mmap__read_forward(struct perf_mmap *md, bool overwrite)
>  {
> -	struct perf_mmap *md = &evlist->mmap[idx];
>  	u64 head;
>  	u64 old = md->prev;
>  
> @@ -795,13 +795,12 @@ union perf_event *perf_evlist__mmap_read_forward(struct perf_evlist *evlist, int
>  
>  	head = perf_mmap__read_head(md);
>  
> -	return perf_mmap__read(md, evlist->overwrite, old, head, &md->prev);
> +	return perf_mmap__read(md, overwrite, old, head, &md->prev);
>  }
>  
>  union perf_event *
> -perf_evlist__mmap_read_backward(struct perf_evlist *evlist, int idx)
> +perf_mmap__read_backward(struct perf_mmap *md, bool overwrite __maybe_unused)
>  {
> -	struct perf_mmap *md = &evlist->mmap[idx];
>  	u64 head, end;
>  	u64 start = md->prev;
>  
> @@ -836,6 +835,20 @@ perf_evlist__mmap_read_backward(struct perf_evlist *evlist, int idx)
>  	return perf_mmap__read(md, false, start, end, &md->prev);

should you pas evlist->overwrite in here?

thanks,
jirka