Re: [PATCH v15 09/12] perf record: Read from overwritable ring buffer

Jiri Olsa
2016-07-13T14:07:00Z

On Tue, Jul 12, 2016 at 10:00:09AM +0000, Wang Nan wrote:

SNIP

> + * (1): Pause ring buffers for reading
> + * (2): Read from ring buffers
> + * (3): Resume ring buffers for recording
> + */
> +enum overwrite_evt_state {
> + OVERWRITE_EVT_RUNNING,
> + OVERWRITE_EVT_DATA_PENDING,
> + OVERWRITE_EVT_EMPTY,
> +};
>
> struct record {
> struct perf_tool tool;
> @@ -61,6 +85,7 @@ struct record {
> bool buildid_all;
> bool timestamp_filename;
> bool switch_output;
> + enum overwrite_evt_state overwrite_evt_state;
> unsigned long long samples;

I wonder this would be better to have in 'struct evlist',
also 'enum owr_mmap_state' might be better name then

thanks,
jirka