* [patch] kconfig: Add some missing curly braces
@ 2016-07-13 22:34 Dan Carpenter
2016-07-14 2:10 ` Luis R. Rodriguez
2016-07-16 15:27 ` Masahiro Yamada
0 siblings, 2 replies; 3+ messages in thread
From: Dan Carpenter @ 2016-07-13 22:34 UTC (permalink / raw)
To: Yann E. MORIN, Luis R. Rodriguez
Cc: linux-kbuild, linux-kernel, kernel-janitors, Michal Marek
There are missing curly braces here so we print some stuff to stderr
which we hadn't intended.
Fixes: 1c199f2878f6 ('kbuild: document recursive dependency limitation / resolution')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/scripts/kconfig/symbol.c b/scripts/kconfig/symbol.c
index 2432298..ff0feab 100644
--- a/scripts/kconfig/symbol.c
+++ b/scripts/kconfig/symbol.c
@@ -1127,11 +1127,12 @@ static void sym_check_print_recursive(struct symbol *last_sym)
break;
}
}
- if (stack->sym == last_sym)
+ if (stack->sym == last_sym) {
fprintf(stderr, "%s:%d:error: recursive dependency detected!\n",
prop->file->name, prop->lineno);
fprintf(stderr, "For a resolution refer to Documentation/kbuild/kconfig-language.txt\n");
fprintf(stderr, "subsection \"Kconfig recursive dependency limitations\"\n");
+ }
if (stack->expr) {
fprintf(stderr, "%s:%d:\tsymbol %s %s value contains %s\n",
prop->file->name, prop->lineno,
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [patch] kconfig: Add some missing curly braces
2016-07-13 22:34 [patch] kconfig: Add some missing curly braces Dan Carpenter
@ 2016-07-14 2:10 ` Luis R. Rodriguez
2016-07-16 15:27 ` Masahiro Yamada
1 sibling, 0 replies; 3+ messages in thread
From: Luis R. Rodriguez @ 2016-07-14 2:10 UTC (permalink / raw)
To: Dan Carpenter
Cc: Yann E. MORIN, Luis R. Rodriguez, linux-kbuild, linux-kernel,
kernel-janitors, Michal Marek
On Thu, Jul 14, 2016 at 01:34:33AM +0300, Dan Carpenter wrote:
> There are missing curly braces here so we print some stuff to stderr
> which we hadn't intended.
>
> Fixes: 1c199f2878f6 ('kbuild: document recursive dependency limitation / resolution')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Luis R. Rodriguez <mcgrof@kernel.org>
Luis
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [patch] kconfig: Add some missing curly braces
2016-07-13 22:34 [patch] kconfig: Add some missing curly braces Dan Carpenter
2016-07-14 2:10 ` Luis R. Rodriguez
@ 2016-07-16 15:27 ` Masahiro Yamada
1 sibling, 0 replies; 3+ messages in thread
From: Masahiro Yamada @ 2016-07-16 15:27 UTC (permalink / raw)
To: Dan Carpenter
Cc: Yann E. MORIN, Luis R. Rodriguez, Linux Kbuild mailing list,
Linux Kernel Mailing List, kernel-janitors, Michal Marek
2016-07-14 7:34 GMT+09:00 Dan Carpenter <dan.carpenter@oracle.com>:
> There are missing curly braces here so we print some stuff to stderr
> which we hadn't intended.
>
> Fixes: 1c199f2878f6 ('kbuild: document recursive dependency limitation / resolution')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/scripts/kconfig/symbol.c b/scripts/kconfig/symbol.c
> index 2432298..ff0feab 100644
> --- a/scripts/kconfig/symbol.c
> +++ b/scripts/kconfig/symbol.c
> @@ -1127,11 +1127,12 @@ static void sym_check_print_recursive(struct symbol *last_sym)
> break;
> }
> }
> - if (stack->sym == last_sym)
> + if (stack->sym == last_sym) {
> fprintf(stderr, "%s:%d:error: recursive dependency detected!\n",
> prop->file->name, prop->lineno);
> fprintf(stderr, "For a resolution refer to Documentation/kbuild/kconfig-language.txt\n");
> fprintf(stderr, "subsection \"Kconfig recursive dependency limitations\"\n");
> + }
> if (stack->expr) {
> fprintf(stderr, "%s:%d:\tsymbol %s %s value contains %s\n",
> prop->file->name, prop->lineno,
Good catch!
BTW, another solution is to concatenate three messages into one.
if (stack->sym == last_sym)
fprintf(stderr,
"%s:%d:error: recursive dependency detected!\n"
"For a resolution refer to
Documentation/kbuild/kconfig-language.txt\n"
"subsection \"Kconfig recursive dependency limitations\"\n",
prop->file->name, prop->lineno);
Personally, I prefer this.
It may be a matter of taste, though.
--
Best Regards
Masahiro Yamada
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-07-16 15:28 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-07-13 22:34 [patch] kconfig: Add some missing curly braces Dan Carpenter
2016-07-14 2:10 ` Luis R. Rodriguez
2016-07-16 15:27 ` Masahiro Yamada
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox