From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751648AbcGNIe3 (ORCPT ); Thu, 14 Jul 2016 04:34:29 -0400 Received: from 8bytes.org ([81.169.241.247]:35931 "EHLO theia.8bytes.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751481AbcGNIeW (ORCPT ); Thu, 14 Jul 2016 04:34:22 -0400 Date: Thu, 14 Jul 2016 10:34:20 +0200 From: Joerg Roedel To: Nate Watterson Cc: robin.murphy@arm.com, iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] iommu/iova: validate iova_domain input to put_iova_domain Message-ID: <20160714083420.GR12639@8bytes.org> References: <1468435772-27905-1-git-send-email-nwatters@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1468435772-27905-1-git-send-email-nwatters@codeaurora.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jul 13, 2016 at 02:49:32PM -0400, Nate Watterson wrote: > Passing a NULL or uninitialized iova_domain into put_iova_domain > will currently crash the kernel when the unconfigured iova_domain > data members are accessed. To prevent this from occurring, this patch > adds a check to make sure that the domain is non-NULL and that the > domain granule is non-zero. The granule can be used to check if the > domain was properly initialized because calling init_iova_domain > with a granule of zero would have already triggered a BUG statement > crashing the kernel. Have you seen real crashes happening because of this? Joerg