From: Ingo Molnar <mingo@kernel.org>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Dave Hansen <dave.hansen@linux.intel.com>,
Timur Tabi <timur@freescale.com>,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch 1/2] drivers/virt: fix the error handling in ioctl_dtprop()
Date: Thu, 14 Jul 2016 14:59:49 +0200 [thread overview]
Message-ID: <20160714125949.GB21281@gmail.com> (raw)
In-Reply-To: <20160714114139.GK18175@mwanda>
* Dan Carpenter <dan.carpenter@oracle.com> wrote:
> If strndup_user() user fails then it returns an error pointer and we
> pass that to kfree() which causes an oops.
Hm, in addition to this fix wouldn't it be better to not crash if kfree() gets
passed an error pointer? Would that have changed the pattern of this particular
bug?
Thanks,
Ingo
prev parent reply other threads:[~2016-07-14 12:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-14 11:41 [patch 1/2] drivers/virt: fix the error handling in ioctl_dtprop() Dan Carpenter
2016-07-14 12:59 ` Ingo Molnar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160714125949.GB21281@gmail.com \
--to=mingo@kernel.org \
--cc=dan.carpenter@oracle.com \
--cc=dave.hansen@linux.intel.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=timur@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox