From: Steven Rostedt <rostedt@goodmis.org>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: Jiri Pirko <jiri@resnulli.us>,
netdev@vger.kernel.org, davem@davemloft.net, arnd@arndb.de,
linux-kernel@vger.kernel.org, idosch@mellanox.com,
yotamg@mellanox.com, eladr@mellanox.com, nogahf@mellanox.com,
ogerlitz@mellanox.com, ivecera@redhat.com, mingo@redhat.com,
jolsa@kernel.org
Subject: Re: [patch net-next 2/2] devlink: fix trace format string
Date: Thu, 14 Jul 2016 13:18:29 -0400 [thread overview]
Message-ID: <20160714131829.36ae548b@gandalf.local.home> (raw)
In-Reply-To: <b94d448d-6009-e444-bd98-abdc848cfb00@infradead.org>
On Thu, 14 Jul 2016 10:07:38 -0700
Randy Dunlap <rdunlap@infradead.org> wrote:
> On 07/14/16 02:37, Jiri Pirko wrote:
> > From: Arnd Bergmann <arnd@arndb.de>
> >
> > Including devlink.h on ARM and probably other 32-bit architectures results in
> > a harmless warning:
> >
> > In file included from ../include/trace/define_trace.h:95:0,
> > from ../include/trace/events/devlink.h:51,
> > from ../net/core/devlink.c:30:
> > include/trace/events/devlink.h: In function 'trace_raw_output_devlink_hwmsg':
> > include/trace/events/devlink.h:42:12: error: format '%lu' expects argument of type 'long unsigned int', but argument 10 has type 'size_t {aka unsigned int}' [-Werror=format=]
> >
> > The correct format string for 'size_t' is %zu, not %lu, this works on all
> > architectures.
> >
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> > Fixes: e5224f0fe2ac ("devlink: add hardware messages tracing facility")
> > Signed-off-by: Jiri Pirko <jiri@mellanox.com>
>
> Acked-by: Randy Dunlap <rdunlap@infradead.org>
>
ditto!
-- Steve
next prev parent reply other threads:[~2016-07-14 17:18 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-14 9:37 [patch net-next 1/2] tracing: change owner name to driver name for devlink hwmsg tracepoint Jiri Pirko
2016-07-14 9:37 ` [patch net-next 2/2] devlink: fix trace format string Jiri Pirko
2016-07-14 17:07 ` Randy Dunlap
2016-07-14 17:18 ` Steven Rostedt [this message]
2016-07-15 5:16 ` David Miller
2016-07-14 17:07 ` [patch net-next 1/2] tracing: change owner name to driver name for devlink hwmsg tracepoint Randy Dunlap
2016-07-14 17:11 ` Steven Rostedt
2016-07-15 5:16 ` David Miller
-- strict thread matches above, loose matches on Subject: below --
2016-07-13 21:03 [PATCH net-next 1/2] devlink: fix build error for CONFIG_MODULES=n Arnd Bergmann
2016-07-13 21:03 ` [PATCH net-next 2/2] devlink: fix trace format string Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160714131829.36ae548b@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=arnd@arndb.de \
--cc=davem@davemloft.net \
--cc=eladr@mellanox.com \
--cc=idosch@mellanox.com \
--cc=ivecera@redhat.com \
--cc=jiri@resnulli.us \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=nogahf@mellanox.com \
--cc=ogerlitz@mellanox.com \
--cc=rdunlap@infradead.org \
--cc=yotamg@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox