From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752099AbcGNRWH (ORCPT ); Thu, 14 Jul 2016 13:22:07 -0400 Received: from libra.uberspace.de ([95.143.172.171]:48022 "EHLO libra.uberspace.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751896AbcGNRWF (ORCPT ); Thu, 14 Jul 2016 13:22:05 -0400 Date: Thu, 14 Jul 2016 19:22:00 +0200 From: Matthias Beyer To: "Zhu, Rex" Cc: "linuxdev.baldrick@gmail.com" , "Deucher, Alexander" , "Koenig, Christian" , "airlied@linux.ie" , "dri-devel@lists.freedesktop.org" , "dcb314@hotmail.com" , "linux-kernel@vger.kernel.org" , "Huang, JinHuiEric" , "nils.wallmenius@gmail.com" Subject: Re: [PATCH] drivers: gpu: drm: amd: powerplay: hwmgr: Remove unused variable Message-ID: <20160714172200.GA16072@yuu> Reply-To: Matthias Beyer References: <20160630163849.3914-2-mail@beyermatthias.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="bp/iNruPH9dso1Pn" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.6.0 (2016-04-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --bp/iNruPH9dso1Pn Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi list, I just wondered: I send the patch >14 days ago, 9 days ago it was=20 reviewed by Rex Zhu. As far as I know, it isn't applied by now. At=20 least I did not get a mail indicating that it was applied. Are there issues with the patch I missed? On 05-07-2016 15:06:59, Zhu, Rex wrote: >=20 > Yes, stretch_amount2 was not used on Polaris. >=20 >=20 > Patch was Reviewed-by: Rex Zhu >=20 >=20 > Thanks. >=20 >=20 > Best Regards >=20 > Rex >=20 > ________________________________ > From: Matthias Beyer > Sent: Friday, July 1, 2016 12:38:49 AM > To: linuxdev.baldrick@gmail.com > Cc: Deucher, Alexander; Koenig, Christian; airlied@linux.ie; dri-devel@li= sts.freedesktop.org; dcb314@hotmail.com; linux-kernel@vger.kernel.org; Zhu,= Rex; Huang, JinHuiEric; nils.wallmenius@gmail.com; Matthias Beyer > Subject: [PATCH] drivers: gpu: drm: amd: powerplay: hwmgr: Remove unused = variable >=20 > Signed-off-by: Matthias Beyer > --- > drivers/gpu/drm/amd/powerplay/hwmgr/polaris10_hwmgr.c | 9 +++------ > 1 file changed, 3 insertions(+), 6 deletions(-) >=20 > diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/polaris10_hwmgr.c b/driv= ers/gpu/drm/amd/powerplay/hwmgr/polaris10_hwmgr.c > index 64ee78f..1dcd52d 100644 > --- a/drivers/gpu/drm/amd/powerplay/hwmgr/polaris10_hwmgr.c > +++ b/drivers/gpu/drm/amd/powerplay/hwmgr/polaris10_hwmgr.c > @@ -1761,7 +1761,7 @@ static int polaris10_populate_clock_stretcher_data_= table(struct pp_hwmgr *hwmgr) > { > uint32_t ro, efuse, volt_without_cks, volt_with_cks, value, max,= min; > struct polaris10_hwmgr *data =3D (struct polaris10_hwmgr *)(hwmg= r->backend); > - uint8_t i, stretch_amount, stretch_amount2, volt_offset =3D 0; > + uint8_t i, stretch_amount, volt_offset =3D 0; > struct phm_ppt_v1_information *table_info =3D > (struct phm_ppt_v1_information *)(hwmgr->pptable= ); > struct phm_ppt_v1_clock_voltage_dependency_table *sclk_table =3D > @@ -1806,11 +1806,8 @@ static int polaris10_populate_clock_stretcher_data= _table(struct pp_hwmgr *hwmgr) > } >=20 > /* Populate CKS Lookup Table */ > - if (stretch_amount =3D=3D 1 || stretch_amount =3D=3D 2 || stretch= _amount =3D=3D 5) > - stretch_amount2 =3D 0; > - else if (stretch_amount =3D=3D 3 || stretch_amount =3D=3D 4) > - stretch_amount2 =3D 1; > - else { > + if (stretch_amount !=3D 1 && stretch_amount !=3D 2 && stretch_amo= unt !=3D 3 && > + stretch_amount !=3D 4 && stretch_amount !=3D 5) { > phm_cap_unset(hwmgr->platform_descriptor.platformCaps, > PHM_PlatformCaps_ClockStretcher); > PP_ASSERT_WITH_CODE(false, > -- > 2.9.0 >=20 --=20 Mit freundlichen Gr=FC=DFen, Kind regards, Matthias Beyer Proudly sent with mutt. Happily signed with gnupg. --bp/iNruPH9dso1Pn Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJXh8o2AAoJEM6vG2R+1WslefoQAJn+oP8N4w2GNNrMMRRnz/5L 7InvNPY192wm9x5M0NiRJuPNOrToV4XP7l1B4penYFQ9ZTUS3QVSTZgeSP63yOSG C4ukzszFuIMJwuXnLagpVbLPPilTxL9mvvnPUb7YGSSNu1iLLQX+qL7Y+OV+/ClP 4L8ZFHSINZOgaaAeFHdxZPUR/3nAjxKhKRTio4Xm9lIRV/3Xkq0r5yFAzCxu4iAQ 5sHDWDCpBPGefKnZOySQWxyP0p9YqDkDFMt9Bg4nJ54W+d5mxn7iUgh+AgrHSR3D fVyFaRtFjfz5aV+Xm3+ge5gFC8SUVe/rMywXJkF5vbjEw+lltGA1YsvlvDfRL67Z yO4jMsU/pv4j8UMmX+do/mVuZG0oxty1QLgXuiSENU8qrNkeqirPwTmtoFtcODp8 EQwaij8Pj2so0LatfkaHf2M9CW/GwwJjC8yLJP32dfp8KcZ15Wwl4VIzpx4QmGBS zZG++ilgpLfL2w5ST9XQHlnvLJnI1vK6mLvlXtOpTeXO3RqH/dfHddy8cYJKsnma V/R82ziOcWmAW7lr1nMrFZEKKFAYkB7v3t5PDEOUGr6etuG2Q222dn0W9DS1OJgN skb43DTx1CFiJbDeQFlFFQGmrOGg7E5DrNEfADUO5e1ZR2TgXuiu1utk3TMEFUZf THwIzW3Sz2tBuV86x07Y =43nF -----END PGP SIGNATURE----- --bp/iNruPH9dso1Pn--