Re: [PATCH 5/5] f2fs: use blk_plug in all the possible paths

Jaegeuk Kim
2016-07-15T03:05:06Z

On Thu, Jul 14, 2016 at 07:21:32PM -0700, Christoph Hellwig wrote:
> On Thu, Jul 14, 2016 at 05:46:29PM -0700, Jaegeuk Kim wrote:
> > The main reason is that blk_start_plug can be used to wake up from low-power
> > mode before submitting further bios.
>
> Where does that myth come from?

>From kernel guys working on android.
And, I'm in also doubt they may have done something regarding to power mode
change, by the fact that I've seen annoying performance jitters comparing to
ext4's ones all the time in some android products.

Frankly speaking, I cannot find a concrete reason to remove plugging entirely,
since I can't see big performance differences in all my test results in severs
as well.

Thanks,