From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752425AbcGODXd (ORCPT ); Thu, 14 Jul 2016 23:23:33 -0400 Received: from quartz.orcorp.ca ([184.70.90.242]:49072 "EHLO quartz.orcorp.ca" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751279AbcGODXb (ORCPT ); Thu, 14 Jul 2016 23:23:31 -0400 Date: Thu, 14 Jul 2016 21:23:27 -0600 From: Jason Gunthorpe To: Andrey Pronin Cc: Jarkko Sakkinen , Peter Huewe , Marcel Selhorst , tpmdd-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org, groeck@chromium.org, smbarber@chromium.org, dianders@chromium.org Subject: Re: [PATCH 2/2] tpm: support driver-specific sysfs attrs in tpm_tis_core Message-ID: <20160715032327.GF9347@obsidianresearch.com> References: <1468547496-16215-1-git-send-email-apronin@chromium.org> <1468547496-16215-3-git-send-email-apronin@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1468547496-16215-3-git-send-email-apronin@chromium.org> User-Agent: Mutt/1.5.23 (2014-03-12) X-Broken-Reverse-DNS: no host name found for IP address 10.0.0.151 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jul 14, 2016 at 06:51:36PM -0700, Andrey Pronin wrote: > - WARN_ON(chip->groups_cnt != 0); Nope. > - const struct attribute_group *groups[3]; > + /* up to 4 attribute groups: > + * - driver-specific > + * - common TPM1.2 and TPM2.0 > + * - TPM1.2/2.0-specific > + * - ppi > + */ > + const struct attribute_group *groups[5]; The prior patch needed to have groups[4], every patch much work. > + if (priv->phy_ops->attr_group) > + chip->groups[chip->groups_cnt++] = priv->phy_ops->attr_group; I am really not excited about having driver specific sysfs files. What is the justification for this? Jason