From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752425AbcGODcw (ORCPT <rfc822;w@1wt.eu>);
	Thu, 14 Jul 2016 23:32:52 -0400
Received: from quartz.orcorp.ca ([184.70.90.242]:45893 "EHLO quartz.orcorp.ca"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S932084AbcGODct (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Thu, 14 Jul 2016 23:32:49 -0400
Date: Thu, 14 Jul 2016 21:32:36 -0600
From: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
To: Andrey Pronin <apronin@chromium.org>
Cc: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>,
        Peter Huewe <peterhuewe@gmx.de>, Marcel Selhorst <tpmdd@selhorst.net>,
        tpmdd-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org,
        groeck@chromium.org, smbarber@chromium.org, dianders@chromium.org,
        Christophe Ricard <christophe.ricard@gmail.com>
Subject: Re: [PATCH 2/2] tpm: add driver for cr50 on SPI
Message-ID: <20160715033236.GH9347@obsidianresearch.com>
References: <1468549218-19215-1-git-send-email-apronin@chromium.org>
 <1468549218-19215-3-git-send-email-apronin@chromium.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1468549218-19215-3-git-send-email-apronin@chromium.org>
User-Agent: Mutt/1.5.23 (2014-03-12)
X-Broken-Reverse-DNS: no host name found for IP address 10.0.0.151
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Jul 14, 2016 at 07:20:18PM -0700, Andrey Pronin wrote:

> +static int cr50_spi_read16(struct tpm_tis_data *data, u32 addr, u16 *result)
> +{
> +	int rc;
> +
> +	rc = data->phy_ops->read_bytes(data, addr, sizeof(u16), (u8 *)result);
> +	if (!rc)
> +		*result = le16_to_cpu(*result);
> +	return rc;
> +}

I thought we had core support for this pattern?

Christophe ?

Please change this so this code isn't duplicated.

Jason