From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752503AbcGODep (ORCPT ); Thu, 14 Jul 2016 23:34:45 -0400 Received: from quartz.orcorp.ca ([184.70.90.242]:59961 "EHLO quartz.orcorp.ca" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752152AbcGODen (ORCPT ); Thu, 14 Jul 2016 23:34:43 -0400 Date: Thu, 14 Jul 2016 21:34:39 -0600 From: Jason Gunthorpe To: Andrey Pronin Cc: Jarkko Sakkinen , Peter Huewe , Marcel Selhorst , tpmdd-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org, groeck@chromium.org, smbarber@chromium.org, dianders@chromium.org Subject: Re: [PATCH 1/2] tpm: add sysfs attributes for tpm2 Message-ID: <20160715033439.GI9347@obsidianresearch.com> References: <1468547496-16215-1-git-send-email-apronin@chromium.org> <1468547496-16215-2-git-send-email-apronin@chromium.org> <20160715032145.GE9347@obsidianresearch.com> <20160715033201.GA27104@apronin> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160715033201.GA27104@apronin> User-Agent: Mutt/1.5.23 (2014-03-12) X-Broken-Reverse-DNS: no host name found for IP address 10.0.0.151 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jul 14, 2016 at 08:32:01PM -0700, Andrey Pronin wrote: > tpm2 shares some of the attributes with tpm1 (e.g. timeouts). Do I still > just add those separately for tpm2 to groups[1] and keep groups[0] empty? I think so. Since the file never exists for tpm2, nothing coded for tpm2 will ever look in the old location. Jason