From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932654AbcGOLM5 (ORCPT ); Fri, 15 Jul 2016 07:12:57 -0400 Received: from mail-lf0-f68.google.com ([209.85.215.68]:33189 "EHLO mail-lf0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932511AbcGOLMx (ORCPT ); Fri, 15 Jul 2016 07:12:53 -0400 Date: Fri, 15 Jul 2016 13:12:55 +0200 From: Johan Hovold To: Mathieu OTHACEHE Cc: johan@kernel.org, gregkh@linuxfoundation.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 08/36] usb: serial: ti_usb_3410_5052: Remove useless dev_dbg messages Message-ID: <20160715111255.GG8809@localhost> References: <1463042948-12205-1-git-send-email-m.othacehe@gmail.com> <1463042948-12205-9-git-send-email-m.othacehe@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1463042948-12205-9-git-send-email-m.othacehe@gmail.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 12, 2016 at 10:48:40AM +0200, Mathieu OTHACEHE wrote: > Remove useless or redundant dev_dbg messages. > Fix debug-message typos. > > Signed-off-by: Mathieu OTHACEHE > --- > drivers/usb/serial/ti_usb_3410_5052.c | 28 +++++++++------------------- > 1 file changed, 9 insertions(+), 19 deletions(-) > > diff --git a/drivers/usb/serial/ti_usb_3410_5052.c b/drivers/usb/serial/ti_usb_3410_5052.c > index 1860a5a..88aacf5 100644 > @@ -846,7 +837,6 @@ static int ti_write_room(struct tty_struct *tty) > room = kfifo_avail(&port->write_fifo); > spin_unlock_irqrestore(&tport->tp_lock, flags); > > - dev_dbg(&port->dev, "%s - returns %d\n", __func__, room); > return room; > } > > @@ -865,7 +855,6 @@ static int ti_chars_in_buffer(struct tty_struct *tty) > chars = kfifo_len(&port->write_fifo); > spin_unlock_irqrestore(&tport->tp_lock, flags); > > - dev_dbg(&port->dev, "%s - returns %d\n", __func__, chars); > return chars; > } While I agree with most of this, the above two can actually be useful to keep. > @@ -924,11 +913,9 @@ static int ti_ioctl(struct tty_struct *tty, > > switch (cmd) { > case TIOCGSERIAL: > - dev_dbg(&port->dev, "%s - TIOCGSERIAL\n", __func__); > return ti_get_serial_info(tport, > (struct serial_struct __user *)arg); > case TIOCSSERIAL: > - dev_dbg(&port->dev, "%s - TIOCSSERIAL\n", __func__); > return ti_set_serial_info(tty, tport, > (struct serial_struct __user *)arg); > } > @@ -950,9 +937,15 @@ static void ti_set_termios(struct tty_struct *tty, > cflag = tty->termios.c_cflag; > iflag = tty->termios.c_iflag; > > - dev_dbg(&port->dev, "%s - cflag %08x, iflag %08x\n", __func__, cflag, iflag); > - dev_dbg(&port->dev, "%s - old clfag %08x, old iflag %08x\n", __func__, > - old_termios->c_cflag, old_termios->c_iflag); > + dev_dbg(&port->dev, > + "%s - cflag 0x%08x, iflag 0x%08x\n", __func__, cflag, iflag); > + > + if (old_termios) { > + dev_dbg(&port->dev, "%s - old clfag 0x%08x, old iflag 0x%08x\n", > + __func__, > + old_termios->c_cflag, > + old_termios->c_iflag); > + } old_termios is not used in the function, why not drop it instead and fix up the call sites? Note that it will currently never be NULL. > > if (tport == NULL) > return; > @@ -1140,8 +1133,6 @@ static void ti_break(struct tty_struct *tty, int break_state) > struct ti_port *tport = usb_get_serial_port_data(port); > int status; > > - dev_dbg(&port->dev, "%s - state = %d\n", __func__, break_state); I'd keep this one as well. > - > if (tport == NULL) > return; > > @@ -1220,7 +1211,6 @@ static void ti_interrupt_callback(struct urb *urb) > > case TI_CODE_MODEM_STATUS: > msr = data[1]; > - dev_dbg(dev, "%s - port %d, msr 0x%02X\n", __func__, port_number, msr); > ti_handle_new_msr(tport, msr); > break; And this one. Thanks, Johan